Bug 48324

Summary: [Qt] Skipping popup focus test for symbian
Product: WebKit Reporter: Yi Shen <max.hong.shen>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar, commit-queue, kling, suresh.voruganti
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: S60 3rd edition   
Attachments:
Description Flags
skipping popupFocus for symbian none

Yi Shen
Reported 2010-10-26 07:31:57 PDT
in tst_qwebframe the popup focus test is based on the usage of a QComboBox by QtWebKit to provide combo popups. As symbian does not use a QComboBox for that the test does not make sense for symbian.
Attachments
skipping popupFocus for symbian (1.43 KB, patch)
2010-10-26 07:45 PDT, Yi Shen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yi Shen
Comment 1 2010-10-26 07:45:11 PDT
Created attachment 71882 [details] skipping popupFocus for symbian
Andreas Kling
Comment 2 2010-10-26 07:49:07 PDT
Comment on attachment 71882 [details] skipping popupFocus for symbian LGTM.
WebKit Commit Bot
Comment 3 2010-10-26 12:49:10 PDT
Comment on attachment 71882 [details] skipping popupFocus for symbian Clearing flags on attachment: 71882 Committed r70558: <http://trac.webkit.org/changeset/70558>
WebKit Commit Bot
Comment 4 2010-10-26 12:49:15 PDT
All reviewed patches have been landed. Closing bug.
Suresh Voruganti
Comment 5 2010-11-02 10:22:35 PDT
Pls cherry pick the fix for Qtwebkit 2.1 branch.
Ademar Reis
Comment 6 2010-11-03 10:25:10 PDT
Revision r70558 cherry-picked into qtwebkit-2.1 with commit 136130c <http://gitorious.org/webkit/qtwebkit/commit/136130c>
Note You need to log in before you can comment on or make changes to this bug.