Bug 48319

Summary: [Qt] Some unit tests try to use the data:<content-type>,<content> URL syntax with setHtml
Product: WebKit Reporter: Jocelyn Turcotte <jturcotte>
Component: New BugsAssignee: Jocelyn Turcotte <jturcotte>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar, commit-queue
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Jocelyn Turcotte
Reported 2010-10-26 06:40:45 PDT
[Qt] Unit tests: setHtml("data:text/html,...") -> load(QUrl("data:text/html,..."))
Attachments
Patch (7.28 KB, patch)
2010-10-26 06:49 PDT, Jocelyn Turcotte 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2010-10-26 06:49:47 PDT
Created attachment 71871 [details] Patch
Jocelyn Turcotte
Comment 2 2010-10-26 06:58:58 PDT
This bug causes the tst_QWebElement::frame(), the tst_QGraphicsWebView::crashOnViewlessWebPages() and some tst_QWebPage unit tests to fail.
Andreas Kling
Comment 3 2010-10-26 07:02:16 PDT
Comment on attachment 71871 [details] Patch LGTM
WebKit Commit Bot
Comment 4 2010-10-26 12:35:43 PDT
Comment on attachment 71871 [details] Patch Clearing flags on attachment: 71871 Committed r70556: <http://trac.webkit.org/changeset/70556>
WebKit Commit Bot
Comment 5 2010-10-26 12:35:47 PDT
All reviewed patches have been landed. Closing bug.
Ademar Reis
Comment 6 2010-10-26 13:03:13 PDT
Revision r70556 cherry-picked into qtwebkit-2.1 with commit f5d4208 <http://gitorious.org/webkit/qtwebkit/commit/f5d4208>
Note You need to log in before you can comment on or make changes to this bug.