Bug 48286

Summary: Fix Cache::dumpStats formatting
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, ddkilzer, eric, ggaren, joepeck, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
[PATCH] Make Columns 13 Characters Wide none

Description Joseph Pecoraro 2010-10-25 19:49:14 PDT 
Cache::dumpStats has columns that are 11 characters wide but PurgeableSize is 13 characters long. Messes up later columns.
Comment 1 Joseph Pecoraro 2010-10-25 19:54:15 PDT 
Created attachment 71837 [details]
[PATCH] Make Columns 13 Characters Wide

Now, none of the titles are too wide. Sample output:

    (gdb) p WebCore::cache()->dumpStats()
                  Count         Size          LiveSize      DecodedSize   PurgeableSize PurgedSize   
    ------------- ------------- ------------- ------------- ------------- ------------- -------------
    Images                   38       3965777       3948921       3053452             0             0
    CSS                       3         66663         66663             0             0             0
    XSL                       0             0             0             0             0             0
    JavaScript                4        406906        406906             0             0             0
    Fonts                     0             0             0             0             0             0
    ------------- ------------- ------------- ------------- ------------- ------------- -------------

Note, there could also be a bunch of improvements to add XBL to this list. However, I don't know anyone that actually uses XBL, so I didn't take the time to add it to the list. Let me know if that is a desired improvement. I don't think this output is actually used anywhere in tests, but I'm running tests overnight anyways to see.
Comment 2 Joseph Pecoraro 2010-10-25 19:58:04 PDT 
Nevermind what I said about XBL. I was looking at an outdated file, XBL was recently removed! =)
Comment 3 David Kilzer (:ddkilzer) 2010-10-25 21:05:58 PDT 
Comment on attachment 71837 [details]
[PATCH] Make Columns 13 Characters Wide

r=me
Comment 4 WebKit Commit Bot 2010-10-26 11:30:36 PDT 
Comment on attachment 71837 [details]
[PATCH] Make Columns 13 Characters Wide

Clearing flags on attachment: 71837

Committed r70545: <http://trac.webkit.org/changeset/70545>
Comment 5 WebKit Commit Bot 2010-10-26 11:30:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2010-10-26 12:05:27 PDT 
http://trac.webkit.org/changeset/70545 might have broken Qt Linux Release
The following tests are not passing:
fast/blockflow/floats-in-block-layout.html
fast/blockflow/self-collapsing-block.html
fast/multicol/nested-columns.html
Comment 7 Joseph Pecoraro 2010-10-26 12:14:11 PDT 
(In reply to comment #6)
> http://trac.webkit.org/changeset/70545 might have broken Qt Linux Release
> The following tests are not passing:
> fast/blockflow/floats-in-block-layout.html
> fast/blockflow/self-collapsing-block.html
> fast/multicol/nested-columns.html

Doesn't appear to be related to this change. There were a few other patches that landed at the same time.