Bug 48257

Summary: Make "rl" and "bt" writing-modes work for blocks and lines.
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 46123    
Attachments:
Description Flags
Patch mitz: review+

Description Dave Hyatt 2010-10-25 12:18:54 PDT 
Make "rl" and "bt" writing-modes work for blocks and lines.  This is just the basics.  Repainting and invalidation aren't right yet.
Comment 1 Dave Hyatt 2010-10-25 12:21:33 PDT 
Created attachment 71781 [details]
Patch
Comment 2 mitz 2010-10-25 12:29:29 PDT 
Comment on attachment 71781 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71781&action=review

> WebCore/rendering/InlineBox.h:293
> +    void adjustForFlippedBlocksWritingMode(int& x, int& y);

It’s sad the we keep adding (int, int) methods instead of IntPoint methods.

> WebCore/rendering/InlineTextBox.cpp:904
> +void InlineTextBox::paintTextMatchMarker(GraphicsContext* pt,  const IntPoint& boxOrigin, const DocumentMarker& marker, RenderStyle* style, const Font& font)

Extra space before const IntPoint
Comment 3 Dave Hyatt 2010-10-25 13:06:32 PDT 
Fixed in r70482.  I changed the adjust functions to take points instead of two ints.