Bug 48208

Summary: Inline WTF::bitCount
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Web Template FrameworkAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ddkilzer, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 32828    
Attachments:
Description Flags
Patch none

Patrick R. Gansterer
Reported 2010-10-24 09:09:41 PDT
see patch
Attachments
Patch (2.17 KB, patch)
2010-10-24 09:11 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2010-10-24 09:11:19 PDT
Created attachment 71689 [details] Patch
WebKit Review Bot
Comment 2 2010-10-24 09:15:10 PDT
Attachment 71689 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/wtf/StdLibExtras.h:94: bitwise_cast is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
David Kilzer (:ddkilzer)
Comment 3 2010-10-24 09:37:25 PDT
Comment on attachment 71689 [details] Patch Thanks! r=me
WebKit Commit Bot
Comment 4 2010-10-24 11:53:41 PDT
Comment on attachment 71689 [details] Patch Clearing flags on attachment: 71689 Committed r70419: <http://trac.webkit.org/changeset/70419>
WebKit Commit Bot
Comment 5 2010-10-24 11:53:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.