Bug 48207 – Web Inspector: slowly make old resources panel optional.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Pavel Feldman]

Patch to follow.

[Pavel Feldman]

Created attachment 71684 [details]
[PATCH] Proposed change.

[Pavel Feldman]

Created attachment 71685 [details]
[IMAGE] Screenshot while running with patch (Resources panel).

[Pavel Feldman]

Created attachment 71686 [details]
[IMAGE] Screenshot while running with patch (Network panel).

[Pavel Feldman]

Created attachment 71687 [details]
[IMAGE] Screenshot while running with patch (Resources panel).

[Timothy Hatcher]

Comment on attachment 71684 [details]
[PATCH] Proposed change.

View in context: https://bugs.webkit.org/attachment.cgi?id=71684&action=review

> WebCore/ChangeLog:34
> +        Web Inspector: add support for errors, warnings and search to the storage panel.

Double ChangeLog.

> WebCore/inspector/front-end/inspector.js:-233
> -        if (hiddenPanels.indexOf("scripts") === -1)

Why remove the hidden panels stuff? I think this si used by some OS X WebKit clients.

> WebCore/inspector/front-end/inspector.js:1690
> +    if (WebInspector.resourceManager) {

Add a newline before this one.

[Timothy Hatcher]

I'd like to see the divider column in the new Resources panel be 1px like the other divider lines.

[Timothy Hatcher]

Also the "&utmac…" resource has the wrong name. It should be "__utm.gif", which is what it is in shipping Safari. We should not show query strings in/as the file name.

[Pavel Feldman]

(In reply to comment #6)
> I'd like to see the divider column in the new Resources panel be 1px like the other divider lines.

Will address comments in a separate patch since am in a hurry landing this one - accidentally enabled network panel in the previous commit...

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/AuditsPanel.js
	M	WebCore/inspector/front-end/ExtensionServer.js
	M	WebCore/inspector/front-end/ResourcesPanel.js
	M	WebCore/inspector/front-end/ScriptsPanel.js
	M	WebCore/inspector/front-end/Settings.js
	M	WebCore/inspector/front-end/inspector.js
Committed r70446

[Pavel Feldman]

Created attachment 71751 [details]
[PATCH] Follow up addressing review comments.

[Pavel Feldman]

Created attachment 71752 [details]
[IMAGE] Screenshot while running with patch.

[Timothy Hatcher]

Comment on attachment 71751 [details]
[PATCH] Follow up addressing review comments.

View in context: https://bugs.webkit.org/attachment.cgi?id=71751&action=review

> WebCore/inspector/front-end/StoragePanel.js:578
> +            return false; // Should never get here.

console.error here too?

> WebCore/inspector/front-end/StoragePanel.js:583
> +            return null; // Should never get here.

console.error here too?

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/Resource.js
	M	WebCore/inspector/front-end/StoragePanel.js
	M	WebCore/inspector/front-end/inspector.css
Committed r70454