Bug 48190

Summary:

[WINCE] Port COMPtr.h to WinCE

Product:

WebKit

Reporter:

Patrick R. Gansterer <paroga>

Component:

Platform

Assignee:

Patrick R. Gansterer <paroga>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Other

Attachments:

Description	Flags
Patch	ddkilzer: review-, ddkilzer: commit-queue-
Patch	none

Description Patrick R. Gansterer 2010-10-23 10:22:15 PDT

see patch

Comment 1 Patrick R. Gansterer 2010-10-23 10:36:38 PDT

Created attachment 71646 [details]
Patch

Comment 2 David Kilzer (:ddkilzer) 2010-10-23 10:57:29 PDT

Comment on attachment 71646 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71646&action=review

r- to fix header sort order since this is a cq? patch.

> WebCore/platform/win/COMPtr.h:35
> +#include <wtf/Assertions.h>
> +#include <wtf/HashTraits.h>
>  #include <unknwn.h>

Nit: <unkwn.h> is alphabetically before <wtf/...h>.  Please realphabetize.

> WebCore/platform/win/COMPtr.h:-36
> -#include <WTF/Assertions.h>
> -#include <WTF/HashTraits.h>

Nice catch re: WTF!

Comment 3 Patrick R. Gansterer 2010-10-23 11:05:14 PDT

Created attachment 71648 [details]
Patch

(In reply to comment #2)
> (From update of attachment 71646 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=71646&action=review
> 
> r- to fix header sort order since this is a cq? patch.
Why don't you set it to r+ and add a comment about whats needed to be ok?


> > WebCore/platform/win/COMPtr.h:35
> > +#include <wtf/Assertions.h>
> > +#include <wtf/HashTraits.h>
> >  #include <unknwn.h>
> 
> Nit: <unkwn.h> is alphabetically before <wtf/...h>.  Please realphabetize.
Don't we usually add WebKit headers befor external headers?


> > WebCore/platform/win/COMPtr.h:-36
> > -#include <WTF/Assertions.h>
> > -#include <WTF/HashTraits.h>
> 
> Nice catch re: WTF!
It's windows, so not a real problem until we cross compile form e.g. linux. ;-)

Comment 4 Patrick R. Gansterer 2010-10-23 11:08:01 PDT

(In reply to comment #3)
> > Nit: <unkwn.h> is alphabetically before <wtf/...h>.  Please realphabetize.
> Don't we usually add WebKit headers befor external headers?
See http://webkit.org/coding/coding-style.html at #include Statements point 4:
"Includes of system headers must come after includes of other headers."

Comment 5 David Kilzer (:ddkilzer) 2010-10-23 11:42:41 PDT

Comment on attachment 71648 [details]
Patch

Thanks!  r=me

Comment 6 WebKit Commit Bot 2010-10-23 12:38:22 PDT

The commit-queue encountered the following flaky tests while processing attachment 71648 [details]:

http/tests/xmlhttprequest/remember-bad-password.html
java/lc3/JSObject/ToObject-001.html

Please file bugs against the tests.  The author(s) of the test(s) are ap@webkit.org, ap@webkit.org, and ap@webkit.org.  The commit-queue is continuing to process your patch.

Comment 7 WebKit Commit Bot 2010-10-23 13:00:24 PDT

The commit-queue encountered the following flaky tests while processing attachment 71648 [details]:

http/tests/appcache/remove-cache.html

Please file bugs against the tests.  The author(s) of the test(s) are ap@webkit.org and ap@webkit.org.  The commit-queue is continuing to process your patch.

Comment 8 WebKit Commit Bot 2010-10-23 13:02:22 PDT

Comment on attachment 71648 [details]
Patch

Clearing flags on attachment: 71648

Committed r70398: <http://trac.webkit.org/changeset/70398>

Comment 9 WebKit Commit Bot 2010-10-23 13:02:26 PDT

All reviewed patches have been landed.  Closing bug.