build-webkit: reformat support variables for better maintainability

• Component: Tools / Tests
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

build-webkit: reformat support variables for better maintainability

[David Kilzer (:ddkilzer)]

Created attachment 71638 [details]
Patch v1

[Daniel Bates]

Comment on attachment 71638 [details]
Patch v1

Looks good to me.

r=me

[Daniel Bates]

Comment on attachment 71638 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=71638&action=review

> WebKitTools/Scripts/build-webkit:62
> +    $threeDCanvasSupport,
> +    $threeDRenderingSupport,

These are not in alphabetical order. I take it you were ordering these assuming "threeD" is interpreted as "3D"?

[Daniel Bates]

Comment on attachment 71638 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=71638&action=review

> WebKitTools/Scripts/build-webkit:90
> +    $svgSupport,

This is also not in the correct place if we are alphabetically ordering this list.

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> > WebKitTools/Scripts/build-webkit:62
> > +    $threeDCanvasSupport,
> > +    $threeDRenderingSupport,
> 
> These are not in alphabetical order. I take it you were ordering these assuming "threeD" is interpreted as "3D"?

(In reply to comment #4)
> > WebKitTools/Scripts/build-webkit:90
> > +    $svgSupport,
> 
> This is also not in the correct place if we are alphabetically ordering this list.

I reworded the ChangeLog.  What I did was to alphabetize @features by the name of the feature, then declare the support variables in the same order.  Because variables can't start with a number ("3d"), the $threeD* variables appear at the top of the list.   Also because "Support" is added to the end of all the variable names, $svgSupport is technically out of alphabetical order in the list compared to the other variable names, but it matches the order in @features.

Thanks!

[David Kilzer (:ddkilzer)]

Committed r70412: <http://trac.webkit.org/changeset/70412>