Bug 48183

Summary: Add Gradient::hasAlpha
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: WebCore Misc.Assignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 48180    
Attachments:
Description Flags
Patch
ddkilzer: review-, ddkilzer: commit-queue-
Patch none

Description Patrick R. Gansterer 2010-10-23 05:59:44 PDT 
see patch
Comment 1 Patrick R. Gansterer 2010-10-23 06:03:23 PDT 
Created attachment 71637 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2010-10-23 07:00:37 PDT 
Comment on attachment 71637 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71637&action=review

r- due to the for() loop style issue

> WebCore/platform/graphics/Gradient.cpp:203
> +    for (size_t i = 0; i < m_stops.size(); i++)
> +        if (m_stops[i].alpha < 1)
> +            return true;

The for loop must have curly braces around it because it's body is more than two lines.
Comment 3 Patrick R. Gansterer 2010-10-23 07:11:32 PDT 
Created attachment 71640 [details]
Patch
Comment 4 David Kilzer (:ddkilzer) 2010-10-23 07:16:29 PDT 
Comment on attachment 71640 [details]
Patch

r=me  Thanks!
Comment 5 WebKit Commit Bot 2010-10-23 08:08:56 PDT 
Comment on attachment 71640 [details]
Patch

Clearing flags on attachment: 71640

Committed r70389: <http://trac.webkit.org/changeset/70389>
Comment 6 WebKit Commit Bot 2010-10-23 08:09:00 PDT 
All reviewed patches have been landed.  Closing bug.