Bug 48183

Summary:

Add Gradient::hasAlpha

Product:

WebKit

Reporter:

Patrick R. Gansterer <paroga>

Component:

WebCore Misc.

Assignee:

Patrick R. Gansterer <paroga>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

48180

Attachments:

Description	Flags
Patch	ddkilzer: review-, ddkilzer: commit-queue-
Patch	none

Patrick R. Gansterer

Reported 2010-10-23 05:59:44 PDT

see patch

Attachments
Patch (1.80 KB, patch) 2010-10-23 06:03 PDT, Patrick R. Gansterer	ddkilzer: review- ddkilzer: commit-queue-	Details Formatted Diff Diff
Patch (1.81 KB, patch) 2010-10-23 07:11 PDT, Patrick R. Gansterer	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Patrick R. Gansterer

Comment 1 2010-10-23 06:03:23 PDT

Created attachment 71637 [details] Patch

David Kilzer (:ddkilzer)

Comment 2 2010-10-23 07:00:37 PDT

Comment on attachment 71637 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71637&action=review r- due to the for() loop style issue > WebCore/platform/graphics/Gradient.cpp:203 > + for (size_t i = 0; i < m_stops.size(); i++) > + if (m_stops[i].alpha < 1) > + return true; The for loop must have curly braces around it because it's body is more than two lines.

Patrick R. Gansterer

Comment 3 2010-10-23 07:11:32 PDT

Created attachment 71640 [details] Patch

David Kilzer (:ddkilzer)

Comment 4 2010-10-23 07:16:29 PDT

Comment on attachment 71640 [details] Patch r=me Thanks!

WebKit Commit Bot

Comment 5 2010-10-23 08:08:56 PDT

Comment on attachment 71640 [details] Patch Clearing flags on attachment: 71640 Committed r70389: <http://trac.webkit.org/changeset/70389>

WebKit Commit Bot

Comment 6 2010-10-23 08:09:00 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.