Summary: | Calling FileReader.abort during reading could cause crash | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jian Li <jianli> | ||||||
Component: | WebCore JavaScript | Assignee: | Jian Li <jianli> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dimich, eric.carlson, ericu, kinuko, levin | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Jian Li
2010-10-22 16:48:06 PDT
Created attachment 71610 [details]
Proposed Patch
Created attachment 71611 [details]
Proposed Patch
Removed unneeded file.
Comment on attachment 71611 [details] Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71611&action=review > WebCore/fileapi/FileReader.cpp:266 > + if (m_state != Aborting) Seems like "fail fast" would be better. if (m_state == Aborting) return; Committed as http://trac.webkit.org/changeset/70484. |