Bug 48163

Summary:

Calling FileReader.abort during reading could cause crash

Product:

WebKit

Reporter:

Jian Li <jianli>

Component:

WebCore JavaScript

Assignee:

Jian Li <jianli>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dimich, eric.carlson, ericu, kinuko, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Proposed Patch	jianli: commit-queue-
Proposed Patch	levin: review+, jianli: commit-queue-

Jian Li

Reported 2010-10-22 16:48:06 PDT

Calling FileReader.abort during reading could cause crash

Attachments
Proposed Patch (6.25 KB, patch) 2010-10-22 16:53 PDT, Jian Li	jianli: commit-queue-	Details Formatted Diff Diff
Proposed Patch (5.75 KB, patch) 2010-10-22 16:54 PDT, Jian Li	levin: review+ jianli: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jian Li

Comment 1 2010-10-22 16:53:10 PDT

Jian Li

Comment 2 2010-10-22 16:54:48 PDT

Created attachment 71611 [details] Proposed Patch Removed unneeded file.

David Levin

Comment 3 2010-10-23 11:09:42 PDT

Comment on attachment 71611 [details] Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71611&action=review > WebCore/fileapi/FileReader.cpp:266 > + if (m_state != Aborting) Seems like "fail fast" would be better. if (m_state == Aborting) return;

Jian Li

Comment 4 2010-10-25 13:13:01 PDT

Note You need to log in before you can comment on or make changes to this bug.