Bug 48163

Summary: Calling FileReader.abort during reading could cause crash
Product: WebKit Reporter: Jian Li <jianli>
Component: WebCore JavaScriptAssignee: Jian Li <jianli>
Status: RESOLVED FIXED    
Severity: Normal CC: dimich, eric.carlson, ericu, kinuko, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Proposed Patch
jianli: commit-queue-
Proposed Patch levin: review+, jianli: commit-queue-

Description Jian Li 2010-10-22 16:48:06 PDT
Calling FileReader.abort during reading could cause crash
Comment 1 Jian Li 2010-10-22 16:53:10 PDT
Created attachment 71610 [details]
Proposed Patch
Comment 2 Jian Li 2010-10-22 16:54:48 PDT
Created attachment 71611 [details]
Proposed Patch

Removed unneeded file.
Comment 3 David Levin 2010-10-23 11:09:42 PDT
Comment on attachment 71611 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71611&action=review

> WebCore/fileapi/FileReader.cpp:266
> +    if (m_state != Aborting)

Seems like "fail fast" would be better.

if (m_state == Aborting)
    return;
Comment 4 Jian Li 2010-10-25 13:13:01 PDT
Committed as http://trac.webkit.org/changeset/70484.