Bug 48122

Summary: REGRESSION(r70298): "WebKit win compilation failure" (Requested by yurys on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, pfeldman, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 48058    
Attachments:
Description Flags
ROLLOUT of r70298
yurys: review-, yurys: commit-queue-
Correct rollout patch. none

Description WebKit Review Bot 2010-10-22 04:18:32 PDT
http://trac.webkit.org/changeset/70298 broke the build:
"WebKit win compilation failure" (Requested by yurys on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2010-10-22 04:19:11 PDT
Created attachment 71547 [details]
ROLLOUT of r70298

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Yury Semikhatsky 2010-10-22 04:37:37 PDT
Comment on attachment 71547 [details]
ROLLOUT of r70298

The patch is incorrect.
Comment 3 Yury Semikhatsky 2010-10-22 04:38:42 PDT
Created attachment 71549 [details]
Correct rollout patch.
Comment 4 Yury Semikhatsky 2010-10-22 04:41:51 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	C	WebCore/inspector/ScriptCallStack.h => WebCore/bindings/js/ScriptCallStack.h
	R	WebCore/bindings/js/ScriptCallStackFactory.h => WebCore/bindings/js/ScriptCallFrame.cpp
	R	WebCore/inspector/ScriptCallFrame.h => WebCore/bindings/js/ScriptCallFrame.h
	R	WebCore/bindings/js/ScriptCallStackFactory.cpp => WebCore/bindings/js/ScriptCallStack.cpp
	R	WebCore/inspector/ScriptCallFrame.cpp => WebCore/bindings/v8/ScriptCallFrame.cpp
	R	WebCore/inspector/ScriptArguments.h => WebCore/bindings/v8/ScriptCallFrame.h
	R	WebCore/bindings/v8/ScriptCallStackFactory.cpp => WebCore/bindings/v8/ScriptCallStack.cpp
	R	WebCore/inspector/ScriptCallStack.h => WebCore/bindings/v8/ScriptCallStack.h
	D	WebCore/bindings/v8/ScriptCallStackFactory.h
	D	WebCore/inspector/ScriptArguments.cpp
	D	WebCore/inspector/ScriptCallStack.cpp
	M	WebCore/Android.jscbindings.mk
	M	WebCore/Android.v8bindings.mk
	M	WebCore/CMakeLists.txt
	M	WebCore/ChangeLog
	M	WebCore/GNUmakefile.am
	M	WebCore/WebCore.gypi
	M	WebCore/WebCore.pro
	M	WebCore/WebCore.vcproj/WebCore.vcproj
	M	WebCore/WebCore.xcodeproj/project.pbxproj
	M	WebCore/bindings/js/JSBindingsAllInOne.cpp
	M	WebCore/bindings/js/JSConsoleCustom.cpp
	M	WebCore/bindings/js/ScriptState.h
	M	WebCore/bindings/scripts/CodeGeneratorJS.pm
	M	WebCore/bindings/scripts/CodeGeneratorV8.pm
	M	WebCore/bindings/scripts/test/JS/JSTestObj.cpp
	M	WebCore/bindings/scripts/test/V8/V8TestObj.cpp
	M	WebCore/bindings/v8/ScriptController.cpp
	M	WebCore/bindings/v8/ScriptState.h
	M	WebCore/bindings/v8/V8ConsoleMessage.cpp
	M	WebCore/bindings/v8/V8ConsoleMessage.h
	M	WebCore/bindings/v8/custom/V8ConsoleCustom.cpp
	M	WebCore/dom/NodeFilter.h
	M	WebCore/inspector/ConsoleMessage.cpp
	M	WebCore/inspector/ConsoleMessage.h
	M	WebCore/inspector/InspectorController.cpp
	M	WebCore/inspector/InspectorController.h
	M	WebCore/page/Console.cpp
	M	WebCore/page/Console.h
	M	WebCore/page/Console.idl
Committed r70300