| Summary: | History item and document.location change. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jędrzej Nowacki <jedrzej.nowacki> | ||||
| Component: | History | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, jedrzej.nowacki, mihaip, msrinirao, tonikitoo | ||||
| Priority: | P4 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 71532 [details]
test
I would like to add this test
Comment on attachment 71532 [details]
test
Tests!
The commit-queue encountered the following flaky tests while processing attachment 71532 [details]: java/lc3/JSObject/ToObject-001.html Please file bugs against the tests. The author(s) of the test(s) are ap@webkit.org and ap@webkit.org. The commit-queue is continuing to process your patch. Comment on attachment 71532 [details] test Clearing flags on attachment: 71532 Committed r70315: <http://trac.webkit.org/changeset/70315> All reviewed patches have been landed. Closing bug. FWIW, this behavior already had tests (e.g. http/tests/history/redirect-js-location-before-load.html), which were updated when the change was made: http://trac.webkit.org/changeset/65340. (In reply to comment #6) > FWIW, this behavior already had tests (e.g. http/tests/history/redirect-js-location-before-load.html), which were updated when the change was made: http://trac.webkit.org/changeset/65340. True, I've missed that one. Do you think it is worth to revert my test? If yes I can do it. (In reply to comment #7) > (In reply to comment #6) > > FWIW, this behavior already had tests (e.g. http/tests/history/redirect-js-location-before-load.html), which were updated when the change was made: http://trac.webkit.org/changeset/65340. > > True, I've missed that one. Do you think it is worth to revert my test? If yes I can do it. No, I think it's fine to leave as is. However, if you're going to be making other history-related changes, you may want to add tests to that directory instead. |
Behavior of back / forward history changed between QtWebkit 2.0 and the trunk. <html> <head> <script> document.location = "another url"; </script> </head> <body></body> </html> I believe that page above should not create a history item in the B/F history, which is the current behavior. From user point of view there is no difference between document.location and http redirection. Related mail thread (with real use case): https://lists.webkit.org/pipermail/webkit-qt/2010-October/000902.html