Bug 48083

Summary: Need WebKit2 API for private browsing
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit2Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
pass the preference to WebCore
none
enable private browsing for cookies andersca: review+

Alexey Proskuryakov
Reported 2010-10-21 11:50:23 PDT
One trickier part here is preventing cookies from being stored. Previously, an embedder app was responsible for that. Platform APIs that we have for private browsing are quite different from each other.
Attachments
pass the preference to WebCore (6.52 KB, patch)
2010-10-21 11:55 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
enable private browsing for cookies (27.80 KB, patch)
2010-10-22 14:29 PDT, Alexey Proskuryakov 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2010-10-21 11:55:18 PDT
Created attachment 71467 [details] pass the preference to WebCore
Alexey Proskuryakov
Comment 2 2010-10-21 12:21:45 PDT
Comment on attachment 71467 [details] pass the preference to WebCore Committed <http://trac.webkit.org/changeset/70255>, clearing r+ from landed patch.
Alexey Proskuryakov
Comment 3 2010-10-22 14:29:51 PDT
Created attachment 71595 [details] enable private browsing for cookies
Anders Carlsson
Comment 4 2010-10-22 17:24:35 PDT
Comment on attachment 71595 [details] enable private browsing for cookies Looks good, r=me!
Alexey Proskuryakov
Comment 5 2010-10-23 15:18:09 PDT
Committed second part in <http://trac.webkit.org/changeset/70400>.
Alexey Proskuryakov
Comment 6 2010-10-23 15:19:08 PDT
<rdar://problem/8489082>
Alexey Proskuryakov
Comment 7 2010-10-23 15:33:01 PDT
Windows build fix <http://trac.webkit.org/changeset/70401>.
Note You need to log in before you can comment on or make changes to this bug.