Bug 48079 – [Qt] InspectorClientQt crashes when deleting a qwebpage which has an inspector

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Yi Shen]

Steps to reproduce this issue
1. Launch QtTestBrowser and load a website like 'webkit.org'
2. on the menu bar, choose 'Developer'->'Show Web Inspector'
3. on the menu bar, choose 'Developer'->'QGraphicsView'->'Toggle use of QGraphicsView'

Result, the QtTestBrowser crashes

Following is the calltrace,

#0  0x01e02d01 in WebCore::InspectorClientQt::sendMessageToFrontend (this=0x8242b50, message="{\"type\":\"event\",\"event\":\"disconnectFromBackend\",\"data\":{}}")
    at ../../../WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:258
#1  0x01500051 in WebCore::InspectorFrontend::disconnectFromBackend (this=0x844c370) at generated/InspectorFrontend.cpp:142
#2  0x019d5062 in WebCore::InspectorController::inspectedPageDestroyed (this=0x8264068) at ../../../WebCore/inspector/InspectorController.cpp:184
#3  0x01b3e8e8 in ~Page (this=0x8242ef8, __in_chrg=<value optimized out>) at ../../../WebCore/page/Page.cpp:215
#4  0x01e23934 in ~QWebPagePrivate (this=0x8229c98, __in_chrg=<value optimized out>) at ../../../WebKit/qt/Api/qwebpage.cpp:333
#5  0x01e28304 in ~QWebPage (this=0x820b558, __in_chrg=<value optimized out>) at ../../../WebKit/qt/Api/qwebpage.cpp:1771
#6  0x0807a11c in ~WebPage (this=0x820b558, __in_chrg=<value optimized out>) at ../../../../WebKitTools/QtTestBrowser/webpage.h:39
#7  0x08072c6e in MainWindow::setPage (this=0xb7500a70, page=0x8427c58) at ../../../../WebKitTools/QtTestBrowser/mainwindow.cpp:106
#8  0x08066f5e in LauncherWindow::initializeView (this=0xb7500a70) at ../../../../Web
...

[Yi Shen]

Created attachment 71460 [details]
first try

[Yi Shen]

The problem is that m_inspectedWebPage->d->inspector is NULL in following snippet

bool InspectorClientQt::sendMessageToFrontend(const String& message)
{
    if (m_inspectedWebPage->d->inspector->d->remoteFrontend) { // crash

[Yi Shen]

(In reply to comment #2)
> The problem is that m_inspectedWebPage->d->inspector is NULL in following snippet
> 
> bool InspectorClientQt::sendMessageToFrontend(const String& message)
> {
>     if (m_inspectedWebPage->d->inspector->d->remoteFrontend) { // crash

Sorry, m_inspectedWebPage->d->inspector->d is NULL

[Andreas Kling]

Comment on attachment 71460 [details]
first try

LGTM.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 71460 [details]:

java/lc3/JSObject/ToObject-001.html

Please file bugs against the tests.  The author(s) of the test(s) are [e-mail] and [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 71460 [details]
first try

Clearing flags on attachment: 71460

Committed r70308: <http://trac.webkit.org/changeset/70308>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Suresh Voruganti]

Yi, do we need this patch for Qtwebkit 2.1 branch?

[Yi Shen]

(In reply to comment #8)
> Yi, do we need this patch for Qtwebkit 2.1 branch?

We'd better to have it. Thanks!

[Suresh Voruganti]

Please cherry pick the fix for Qtwebkit 2.1 branch

[Ademar Reis]

Revision r70308 cherry-picked into qtwebkit-2.1 with commit da8bfab <http://gitorious.org/webkit/qtwebkit/commit/da8bfab>