Summary: | [Qt] InspectorClientQt crashes when deleting a qwebpage which has an inspector | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yi Shen <max.hong.shen> | ||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ademar, commit-queue, suresh.voruganti | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Yi Shen
2010-10-21 10:54:43 PDT
Created attachment 71460 [details]
first try
The problem is that m_inspectedWebPage->d->inspector is NULL in following snippet bool InspectorClientQt::sendMessageToFrontend(const String& message) { if (m_inspectedWebPage->d->inspector->d->remoteFrontend) { // crash (In reply to comment #2) > The problem is that m_inspectedWebPage->d->inspector is NULL in following snippet > > bool InspectorClientQt::sendMessageToFrontend(const String& message) > { > if (m_inspectedWebPage->d->inspector->d->remoteFrontend) { // crash Sorry, m_inspectedWebPage->d->inspector->d is NULL Comment on attachment 71460 [details]
first try
LGTM.
The commit-queue encountered the following flaky tests while processing attachment 71460 [details]: java/lc3/JSObject/ToObject-001.html Please file bugs against the tests. The author(s) of the test(s) are ap@webkit.org and ap@webkit.org. The commit-queue is continuing to process your patch. Comment on attachment 71460 [details] first try Clearing flags on attachment: 71460 Committed r70308: <http://trac.webkit.org/changeset/70308> All reviewed patches have been landed. Closing bug. Yi, do we need this patch for Qtwebkit 2.1 branch? (In reply to comment #8) > Yi, do we need this patch for Qtwebkit 2.1 branch? We'd better to have it. Thanks! Please cherry pick the fix for Qtwebkit 2.1 branch Revision r70308 cherry-picked into qtwebkit-2.1 with commit da8bfab <http://gitorious.org/webkit/qtwebkit/commit/da8bfab> |