Bug 48071

Summary:

test-webkitpy fails when passed -v (or any other option)

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dpranke

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Description Eric Seidel (no email) 2010-10-21 09:16:52 PDT

test_get_option__set (webkitpy.layout_tests.port.base_unittest.PortTest) ... Usage: test-webkitpy [options]

test-webkitpy: error: no such option: -v
ERROR


test_set_option_default__set (webkitpy.layout_tests.port.base_unittest.PortTest) ... Usage: test-webkitpy [options]

test-webkitpy: error: no such option: -v
ERROR
test_set_option_default__unset (webkitpy.layout_tests.port.base_unittest.PortTest) ... ok

Comment 1 Eric Seidel (no email) 2010-10-21 09:18:18 PDT

======================================================================
ERROR: test_get_option__set (webkitpy.layout_tests.port.base_unittest.PortTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/port/base_unittest.py", line 253, in test_get_option__set
    options, args = optparse.OptionParser().parse_args()
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/optparse.py", line 1382, in parse_args
    self.error(str(err))
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/optparse.py", line 1564, in error
    self.exit(2, "%s: error: %s\n" % (self.get_prog_name(), msg))
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/optparse.py", line 1554, in exit
    sys.exit(status)
SystemExit: 2

======================================================================
ERROR: test_set_option_default__set (webkitpy.layout_tests.port.base_unittest.PortTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/port/base_unittest.py", line 272, in test_set_option_default__set
    options, args = optparse.OptionParser().parse_args()
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/optparse.py", line 1382, in parse_args
    self.error(str(err))
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/optparse.py", line 1564, in error
    self.exit(2, "%s: error: %s\n" % (self.get_prog_name(), msg))
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/optparse.py", line 1554, in exit
    sys.exit(status)
SystemExit: 2

----------------------------------------------------------------------
Ran 644 tests in 46.632s

Comment 2 Dirk Pranke 2010-10-22 14:57:17 PDT

Created attachment 71599 [details]
Patch

Comment 3 Eric Seidel (no email) 2010-10-22 14:59:50 PDT

Comment on attachment 71599 [details]
Patch

OK.

Comment 4 Dirk Pranke 2010-10-22 15:11:48 PDT

Comment on attachment 71599 [details]
Patch

Clearing flags on attachment: 71599

Committed r70350: <http://trac.webkit.org/changeset/70350>

Comment 5 Dirk Pranke 2010-10-22 15:11:54 PDT

All reviewed patches have been landed.  Closing bug.