|Summary:||[Chromium] fast/repaint/renderer-destruction-by-invalidateSelection-crash needs image rebaseline for linux|
|Product:||WebKit||Reporter:||Julie Parent <jparent>|
|Component:||New Bugs||Assignee:||Julie Parent <jparent>|
|Severity:||Normal||CC:||abarth, commit-queue, tony|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Julie Parent 2010-10-20 14:50:53 PDT
[Chromium] fast/repaint/renderer-destruction-by-invalidateSelection-crash needs image rebaseline for linux
Comment 1 Julie Parent 2010-10-20 14:56:47 PDT
Was incorrectly rebaselined in r61912 (massive rebaseline that was addressing scrollbar changes, but there are no scrollbars in this image) See http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium-linux/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png?rev=61911 vs http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium-linux/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png?rev=61912
Comment 3 Tony Chang 2010-10-20 15:19:02 PDT
Should there be a change to test_expectations? It looks like the text output needs an update too?
Comment 4 Julie Parent 2010-10-20 15:20:35 PDT
No, the test still has a race condition, causing it to fail sporadically on both windows and linux (which is the text change you are seeing). It isn't correct to rebaseline that part.
Comment 5 WebKit Commit Bot 2010-10-21 03:32:44 PDT
The commit-queue encountered the following flaky tests while processing attachment 71346 [details]: http/tests/websocket/tests/multiple-connections.html Please file bugs against the tests. The author(s) of the test(s) have been CCed on this bug. The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2010-10-21 03:33:42 PDT
Comment on attachment 71346 [details] Patch Clearing flags on attachment: 71346 Committed r70224: <http://trac.webkit.org/changeset/70224>
Comment 7 WebKit Commit Bot 2010-10-21 03:33:48 PDT
All reviewed patches have been landed. Closing bug.