| Summary: | [Chromium] fast/repaint/renderer-destruction-by-invalidateSelection-crash needs image rebaseline for linux | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Julie Parent <jparent> | ||||
| Component: | New Bugs | Assignee: | Julie Parent <jparent> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, commit-queue, tony | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Julie Parent
2010-10-20 14:50:53 PDT
Was incorrectly rebaselined in r61912 (massive rebaseline that was addressing scrollbar changes, but there are no scrollbars in this image) See http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium-linux/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png?rev=61911 vs http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium-linux/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png?rev=61912 Created attachment 71346 [details]
Patch
Should there be a change to test_expectations? It looks like the text output needs an update too? No, the test still has a race condition, causing it to fail sporadically on both windows and linux (which is the text change you are seeing). It isn't correct to rebaseline that part. The commit-queue encountered the following flaky tests while processing attachment 71346 [details]:
http/tests/websocket/tests/multiple-connections.html
Please file bugs against the tests. The author(s) of the test(s) have been CCed on this bug. The commit-queue is continuing to process your patch.
Comment on attachment 71346 [details] Patch Clearing flags on attachment: 71346 Committed r70224: <http://trac.webkit.org/changeset/70224> All reviewed patches have been landed. Closing bug. |
