Bug 48009

Summary:

[Chromium] fast/repaint/renderer-destruction-by-invalidateSelection-crash needs image rebaseline for linux

Product:

WebKit

Reporter:

Julie Parent <jparent>

Component:

New Bugs

Assignee:

Julie Parent <jparent>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Julie Parent

Reported 2010-10-20 14:50:53 PDT

[Chromium] fast/repaint/renderer-destruction-by-invalidateSelection-crash needs image rebaseline for linux

Attachments
Patch (5.70 KB, patch) 2010-10-20 15:06 PDT, Julie Parent	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Julie Parent

Comment 1 2010-10-20 14:56:47 PDT

Was incorrectly rebaselined in r61912 (massive rebaseline that was addressing scrollbar changes, but there are no scrollbars in this image) See http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium-linux/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png?rev=61911 vs http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium-linux/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png?rev=61912

Julie Parent

Comment 2 2010-10-20 15:06:06 PDT

Created attachment 71346 [details] Patch

Tony Chang

Comment 3 2010-10-20 15:19:02 PDT

Should there be a change to test_expectations? It looks like the text output needs an update too?

Julie Parent

Comment 4 2010-10-20 15:20:35 PDT

No, the test still has a race condition, causing it to fail sporadically on both windows and linux (which is the text change you are seeing). It isn't correct to rebaseline that part.

WebKit Commit Bot

Comment 5 2010-10-21 03:32:44 PDT

The commit-queue encountered the following flaky tests while processing attachment 71346 [details]: http/tests/websocket/tests/multiple-connections.html Please file bugs against the tests. The author(s) of the test(s) have been CCed on this bug. The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 6 2010-10-21 03:33:42 PDT

Comment on attachment 71346 [details] Patch Clearing flags on attachment: 71346 Committed r70224: <http://trac.webkit.org/changeset/70224>

WebKit Commit Bot

Comment 7 2010-10-21 03:33:48 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.