Bug 47993

Summary: Out of process plug-ins are never asked to initially paint
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch darin: review+

Description Anders Carlsson 2010-10-20 10:36:54 PDT
Out of process plug-ins are never asked to initially paint
Comment 1 Anders Carlsson 2010-10-20 11:01:34 PDT
<rdar://problem/8570342>
Comment 2 Anders Carlsson 2010-10-20 11:08:59 PDT
Created attachment 71311 [details]
Patch
Comment 3 Darin Adler 2010-10-20 11:34:56 PDT
Comment on attachment 71311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71311&action=review

> WebKit2/PluginProcess/PluginControllerProxy.cpp:299
> +    m_paintTimer.stop();
> +
> +    paint();

I could imagine putting the call to m_paintTimer.stop() inside paint(). At the moment, it’s OK to leave it outside like this. I think the blank line before paint doesn’t make much sense. I suggest grouping it all in one paragraph.

> WebKit2/WebProcess/Plugins/PluginProxy.cpp:120
> +        m_connection->connection()->sendSync(Messages::PluginControllerProxy::PaintEntirePlugin(), 
> +                                             Messages::PluginControllerProxy::PaintEntirePlugin::Reply(),
> +                                             m_pluginInstanceID, CoreIPC::Connection::NoTimeout);

I suggest not lining up subsequent lines with the opening parenthesis. It’s not easy to maintain when renaming things in the future, and also makes things take more lines than they otherwise would.
Comment 4 Anders Carlsson 2010-10-20 12:38:50 PDT
Committed r70162: <http://trac.webkit.org/changeset/70162>