Bug 47993 – Out of process plug-ins are never asked to initially paint

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

Out of process plug-ins are never asked to initially paint

[Anders Carlsson]

<rdar://problem/8570342>

[Anders Carlsson]

Created attachment 71311 [details]
Patch

[Darin Adler]

Comment on attachment 71311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71311&action=review

> WebKit2/PluginProcess/PluginControllerProxy.cpp:299
> +    m_paintTimer.stop();
> +
> +    paint();

I could imagine putting the call to m_paintTimer.stop() inside paint(). At the moment, it’s OK to leave it outside like this. I think the blank line before paint doesn’t make much sense. I suggest grouping it all in one paragraph.

> WebKit2/WebProcess/Plugins/PluginProxy.cpp:120
> +        m_connection->connection()->sendSync(Messages::PluginControllerProxy::PaintEntirePlugin(), 
> +                                             Messages::PluginControllerProxy::PaintEntirePlugin::Reply(),
> +                                             m_pluginInstanceID, CoreIPC::Connection::NoTimeout);

I suggest not lining up subsequent lines with the opening parenthesis. It’s not easy to maintain when renaming things in the future, and also makes things take more lines than they otherwise would.

[Anders Carlsson]

Committed r70162: <http://trac.webkit.org/changeset/70162>