| Summary: | Max width of a floated container with floated children calculated incorrectly | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Bruno Couto <bmcouto> | ||||||
| Component: | CSS | Assignee: | Robert Hogan <robert> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Major | CC: | bmcouto, dglazkov, donggwan.kim, eric, ojan.autocc, robert, s.choi, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows 7 | ||||||||
| URL: | http://jsfiddle.net/Trn8M/ | ||||||||
| Attachments: |
|
||||||||
|
Description
Bruno Couto
2010-10-20 02:16:22 PDT
This looks fine in Chromium20. Closing - but please comment here if you can still recreate it. Still happens on Chrome Version 22.0.1229.79 Can you be more specific about the problem so? I don't know what the broken rendering looks like. Just go to the jsfiddle, and change letter-spacing:normal; in .label class to another value or even remove it. You will notice that the width of it's container change to weird values without reason. Only happens on webkit browsers. I see it now - thanks for the clarification. Happy to help! Hope it's an easy fix. Created attachment 180605 [details]
Patch
Comment on attachment 180605 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180605&action=review Patch doesn't apply to ToT :( r=me after the nits are addressed. > Source/WebCore/ChangeLog:3 > + letter-spacing set's weird width when clearing floats Update the title to describe the actual bug, since letter-spacing isn't the issue here. > LayoutTests/fast/block/float/max-width-clear-float-with-overflow-hidden.html:1 > +<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd"> Why the long doctype instead of just !DOCTYPE html? Created attachment 181345 [details]
Patch
Comment on attachment 181345 [details] Patch Clearing flags on attachment: 181345 Committed r138899: <http://trac.webkit.org/changeset/138899> All reviewed patches have been landed. Closing bug. For some reason, the added test has been failing on MoLion ever since it was added: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fblock%2Ffloat%2Fmax-width-clear-float-with-overflow-hidden.html (In reply to comment #12) > For some reason, the added test has been failing on MoLion ever since it was added: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fblock%2Ffloat%2Fmax-width-clear-float-with-overflow-hidden.html Anyone? Bueller?... (In reply to comment #13) > (In reply to comment #12) > > For some reason, the added test has been failing on MoLion ever since it was added: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fblock%2Ffloat%2Fmax-width-clear-float-with-overflow-hidden.html > > Anyone? Bueller?... I looked and figured it must be something to do with Ahem on that platform. Is it OK to skip it for now and assign a bug to me to turn it into a text test? (In reply to comment #14) > (In reply to comment #13) > > (In reply to comment #12) > > > For some reason, the added test has been failing on MoLion ever since it was added: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fblock%2Ffloat%2Fmax-width-clear-float-with-overflow-hidden.html > > > > Anyone? Bueller?... > > I looked and figured it must be something to do with Ahem on that platform. Is it OK to skip it for now and assign a bug to me to turn it into a text test? Okay. |