Bug 47969

Summary: Unify globalData APIs
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit-ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
globaldataref.diff
none
globaldataref.diff
none
globaldataref.diff
none
globaldata.diff none

Xan Lopez
Reported 2010-10-20 00:09:50 PDT
The globalData getter in JSGlobalObject returns a pointer, while the one in CallFrame.h returns a reference. There was a FIXME in CallFrame.h suggesting to unify them, so the attached patch does that. I wasn't completely sure of which way to go with this, but after some googling I decided to move the getter in JSGlobalObject to return a reference, since it seems it's the preferred thing to do in the public API of classes when there's no need to, say, return NULL in special cases. There's no change in the tests or significant change in SunSpider.
Attachments
globaldataref.diff (29.47 KB, patch)
2010-10-20 00:11 PDT, Xan Lopez 		no flags
DetailsFormatted DiffDiff
globaldataref.diff (32.02 KB, patch)
2010-10-20 00:56 PDT, Xan Lopez 		no flags
DetailsFormatted DiffDiff
globaldataref.diff (35.18 KB, patch)
2010-10-20 02:15 PDT, Xan Lopez 		no flags
DetailsFormatted DiffDiff
globaldata.diff (40.54 KB, patch)
2010-10-20 06:12 PDT, Xan Lopez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2010-10-20 00:11:39 PDT
Created attachment 71257 [details] globaldataref.diff
Early Warning System Bot
Comment 2 2010-10-20 00:34:37 PDT
Attachment 71257 [details] did not build on qt: Build output: http://queues.webkit.org/results/4545007
Xan Lopez
Comment 3 2010-10-20 00:56:57 PDT
Created attachment 71262 [details] globaldataref.diff Try to fix WebKit2 build.
Eric Seidel (no email)
Comment 4 2010-10-20 02:04:33 PDT
Attachment 71257 [details] did not build on mac: Build output: http://queues.webkit.org/results/4514008
Xan Lopez
Comment 5 2010-10-20 02:15:13 PDT
Created attachment 71265 [details] globaldataref.diff And objc bindings.
Eric Seidel (no email)
Comment 6 2010-10-20 03:52:09 PDT
Attachment 71262 [details] did not build on mac: Build output: http://queues.webkit.org/results/4597007
Eric Seidel (no email)
Comment 7 2010-10-20 05:37:14 PDT
Attachment 71265 [details] did not build on mac: Build output: http://queues.webkit.org/results/4576011
Xan Lopez
Comment 8 2010-10-20 06:12:22 PDT
Created attachment 71280 [details] globaldata.diff Fix WebKit/mac
Xan Lopez
Comment 9 2010-10-23 17:15:36 PDT
Comment on attachment 71280 [details] globaldata.diff Landed as r70406.
Xan Lopez
Comment 10 2010-10-23 17:15:47 PDT
Closing bug.
Note You need to log in before you can comment on or make changes to this bug.