| Summary: | Get old-run-webkit-tests mostly working with Win32 Perl | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
| Component: | New Bugs | Assignee: | Adam Roben (:aroben) <aroben> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ddkilzer, sfalken | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 48166 | ||||||
| Attachments: |
|
||||||
|
Description
Adam Roben (:aroben)
2010-10-19 18:07:39 PDT
Created attachment 71237 [details]
Patch
Comment on attachment 71237 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71237&action=review r=me > WebKitTools/Scripts/old-run-webkit-tests:417 > + $dumpToolName .= ".exe"; Optional: I think there is a Perl-ish way to get the executable extension via built-in variable or via the Config module ($Config{_exe}). > WebKitTools/Scripts/old-run-webkit-tests:1331 > + unshift @{$args}, "perl", $execScript; It would be a good idea to extract all of these "perl" strings into a global variable. It will make it easier to replace them or update them later. > WebKitTools/Scripts/webkitdirs.pm:1082 > + print $vcBuildPath, "\n"; Debug print statement? Comment on attachment 71237 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71237&action=review >> WebKitTools/Scripts/old-run-webkit-tests:417 >> + $dumpToolName .= ".exe"; > > Optional: I think there is a Perl-ish way to get the executable extension via built-in variable or via the Config module ($Config{_exe}). OK, I'll use $Config{_exe}. I couldn't find a built-in variable that would give us the string. >> WebKitTools/Scripts/old-run-webkit-tests:1331 >> + unshift @{$args}, "perl", $execScript; > > It would be a good idea to extract all of these "perl" strings into a global variable. It will make it easier to replace them or update them later. Sounds good. I'll use a $perlInterpreter global variable. >> WebKitTools/Scripts/webkitdirs.pm:1082 >> + print $vcBuildPath, "\n"; > > Debug print statement? Indeed! Good catch. Removed. Committed r70188: <http://trac.webkit.org/changeset/70188> |