Bug 47917

Summary:

[Chromium] Populate caps lock state in WebInputEventFactory

Product:

WebKit

Reporter:

Stuart Morgan <stuartmorgan>

Component:

WebKit Misc.

Assignee:

Stuart Morgan <stuartmorgan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
fix	none

Stuart Morgan

Reported 2010-10-19 12:11:12 PDT

WebInputEvent recently acquired a CapsLockOn modifier flag, but it wasn't added to the NSEvent->WebInputEvent conversion path.

Attachments
fix (1.27 KB, patch) 2010-10-26 17:12 PDT, Stuart Morgan	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Stuart Morgan

Comment 1 2010-10-26 17:12:37 PDT

Created attachment 71968 [details] fix

David Levin

Comment 2 2010-10-26 22:11:35 PDT

(In reply to comment #0) > WebInputEvent recently acquired a CapsLockOn modifier flag, but it wasn't added to the NSEvent->WebInputEvent conversion path. It looks like this was added in http://trac.webkit.org/changeset/68047 That change also added NumLockOn but that doesn't seem to be part of this change. Why?

Stuart Morgan

Comment 3 2010-10-27 09:52:25 PDT

Because there's no concept of a num lock flag in NSEvent.

WebKit Commit Bot

Comment 4 2010-10-27 14:38:51 PDT

Comment on attachment 71968 [details] fix Clearing flags on attachment: 71968 Committed r70713: <http://trac.webkit.org/changeset/70713>

WebKit Commit Bot

Comment 5 2010-10-27 14:38:56 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.