Bug 4781

Summary: Date.setMonth fails with big values due to overflow
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: JavaScriptCoreAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 412   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Fix
darin: review+
fast/js/date-big-setmonth.html none

Geoffrey Garen
Reported 2005-08-31 14:38:59 PDT
Attachments
Fix (8.17 KB, patch)
2005-08-31 14:39 PDT, Geoffrey Garen 		darin: review+
DetailsFormatted DiffDiff
fast/js/date-big-setmonth.html (845 bytes, text/html)
2005-09-07 16:15 PDT, Geoffrey Garen 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2005-08-31 14:39:25 PDT
Created attachment 3704 [details] Fix I still need to write a layout test for this.
Darin Adler
Comment 2 2005-09-03 12:12:21 PDT
Comment on attachment 3704 [details] Fix The "containsNaN" function seems like it will go past even the 7th argument, which is probably not the desired behavior. You probably want a maxArgs parameter to that function. Also, that change doesn't seem to be part of the bug fix. So maybe you should land it separately. The main bug fix looks fine, r=me on that. I'm going to set this to review+, but it's really review+ on the first half ot he patch and review- on the second half.
Geoffrey Garen
Comment 3 2005-09-07 16:15:37 PDT
Created attachment 3805 [details] fast/js/date-big-setmonth.html Layout test
Geoffrey Garen
Comment 4 2005-09-07 16:25:47 PDT
OK. I landed the setMonth change minus the containsNaN bit plus the layout test.
Note You need to log in before you can comment on or make changes to this bug.