Summary: | Rename X-Purpose to Purpose | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
Component: | Page Loading | Assignee: | Adam Barth <abarth> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, gavinp, levin, mitz | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Adam Barth
2010-10-18 00:46:43 PDT
Created attachment 71008 [details]
Patch
LGTM (although I'm not a committer). From ChangeLog: "As requested by IETF HTTP WG". There's been some more traffic on the list. They'd like to clarify that it's not an official request. The ADs would like to depreciate using the X- dash prefix, so we should remove it here before we get stuck with it. It'll be awesome to have both "Purpose" and "X-Purpose" in WebKit-based browsers :-( (In reply to comment #5) > It'll be awesome to have both "Purpose" and "X-Purpose" in WebKit-based browsers :-( Can we drop the X- from the Safari feature? (In reply to comment #6) > (In reply to comment #5) > > It'll be awesome to have both "Purpose" and "X-Purpose" in WebKit-based browsers :-( > > Can we drop the X- from the Safari feature? (I'm just going through the review queue and trying to clear things out.) This looks like a simple patch meant to better work with standards, so it seems like an ok candidate to r+. Alexey, do you object to it? I don't know if we can drop X- in Safari. Comment on attachment 71008 [details] Patch Seems fine. You may need to add an #ifdef for Apple if we can't drop X. I don't sit on the IETF WG, but the interwebs seem to support dropping X-: http://tools.ietf.org/html/draft-saintandre-xdash-considered-harmful-00 You should mention http://tools.ietf.org/html/draft-saintandre-xdash-considered-harmful-00 in your ChangeLog? Committed r71494: <http://trac.webkit.org/changeset/71494> |