Summary: | Strict mode: Assignment that would create a global should be a late ReferenceError, not a syntax failure | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||||
Component: | New Bugs | Assignee: | Oliver Hunt <oliver> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ossy, webkit-ews, webkit.review.bot, yong.li.webkit | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | 47801 | ||||||||
Bug Blocks: | 47672 | ||||||||
Attachments: |
|
Description
Oliver Hunt
2010-10-17 20:20:32 PDT
Created attachment 70990 [details]
Patch
Attachment 70990 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/interpreter/Interpreter.cpp:2455: vm_throw is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 1 in 20 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 70990 [details] did not build on qt: Build output: http://queues.webkit.org/results/4404065 Created attachment 70992 [details]
Patch
Attachment 70992 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/interpreter/Interpreter.cpp:2455: vm_throw is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 1 in 20 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r69940: <http://trac.webkit.org/changeset/69940> (In reply to comment #6) > Committed r69940: <http://trac.webkit.org/changeset/69940> It broke the interpreter build, fix landed in http://trac.webkit.org/changeset/69944 Seems this has broken non-JIT JS functionality. When assigning a variable in "catch" block, it always throws this exception. <html> <script> try { throw "test"; } catch (e1) { try { var s; s = e1.message; document.write("succeeded"); } catch (e2) { alert(e2); } } </script> <body> </body> </html> > Seems this has broken non-JIT JS functionality.
Could you please file a bug?
(In reply to comment #9) > > Seems this has broken non-JIT JS functionality. > > Could you please file a bug? Bug 49383 created for this |