Bug 47787

Summary: [EFL] Add setting api for disabling auto resize window
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: antognolli+webkit, commit-queue, leandro, lucas.de.marchi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
CommentApplied none

Ryuan Choi
Reported 2010-10-17 18:25:22 PDT
Javascript like window.resize can change browser size. but mobile browser may want to limit this functionality.
Attachments
Patch (4.54 KB, patch)
2010-10-17 18:41 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
CommentApplied (4.55 KB, patch)
2010-10-19 05:36 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2010-10-17 18:41:42 PDT
Created attachment 70989 [details] Patch
WebKit Review Bot
Comment 2 2010-10-17 18:44:31 PDT
Attachment 70989 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2 Updating OpenSource RA layer request failed: OPTIONS of 'http://svn.webkit.org/repository/webkit': could not connect to server (http://svn.webkit.org) at /usr/lib/git-core/git-svn line 2295 Died at WebKitTools/Scripts/update-webkit line 129. If any of these errors are false positives, please file a bug against check-webkit-style.
Rafael Antognolli
Comment 3 2010-10-19 05:02:15 PDT
Just a note, of the function ewk_view_setting_enable_auto_resize_window_set seems to be wrongly copy-pasted: + * @return EINA_TRUE if flattening status set, EINA_FALSE + * otherwise (errors). Other than that, the patch seems ok, and I don't know why the bot failed. Maybe a temporary connection error?
Ryuan Choi
Comment 4 2010-10-19 05:36:09 PDT
Created attachment 71156 [details] CommentApplied Thank you. I fixed my mistake.
Eric Seidel (no email)
Comment 5 2010-10-19 14:37:30 PDT
Comment on attachment 71156 [details] CommentApplied rubber-stamp based on previous review.
WebKit Commit Bot
Comment 6 2010-10-19 14:58:22 PDT
Comment on attachment 71156 [details] CommentApplied Clearing flags on attachment: 71156 Committed r70091: <http://trac.webkit.org/changeset/70091>
WebKit Commit Bot
Comment 7 2010-10-19 14:58:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.