| Summary: | [EFL] Add setting api for disabling auto resize window | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryuan Choi <ryuan.choi> | ||||||
| Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | antognolli+webkit, commit-queue, leandro, lucas.de.marchi, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Attachments: |
|
||||||||
|
Description
Ryuan Choi
2010-10-17 18:25:22 PDT
Created attachment 70989 [details]
Patch
Attachment 70989 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2 Updating OpenSource RA layer request failed: OPTIONS of 'http://svn.webkit.org/repository/webkit': could not connect to server (http://svn.webkit.org) at /usr/lib/git-core/git-svn line 2295 Died at WebKitTools/Scripts/update-webkit line 129. If any of these errors are false positives, please file a bug against check-webkit-style. Just a note, of the function ewk_view_setting_enable_auto_resize_window_set seems to be wrongly copy-pasted: + * @return EINA_TRUE if flattening status set, EINA_FALSE + * otherwise (errors). Other than that, the patch seems ok, and I don't know why the bot failed. Maybe a temporary connection error? Created attachment 71156 [details]
CommentApplied
Thank you.
I fixed my mistake.
Comment on attachment 71156 [details]
CommentApplied
rubber-stamp based on previous review.
Comment on attachment 71156 [details] CommentApplied Clearing flags on attachment: 71156 Committed r70091: <http://trac.webkit.org/changeset/70091> All reviewed patches have been landed. Closing bug. |