Bug 47783

Summary: Need a WebKit2 equivalent of the WebKit1 WebUserContentURLPattern
Product: WebKit Reporter: Jessie Berlin <jberlin>
Component: WebKit2Assignee: Jessie Berlin <jberlin>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, jberlin, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Adds WebUserContentURLPattern and WKUserContentURLPattern to WebKit2 none

Jessie Berlin
Reported 2010-10-17 14:13:23 PDT
The WebKit2 equivalent would also be a wrapper around the WebCore::UserContentURLPattern class, just like the WebKit1 WebUserContentURLPattern. <rdar://problem/8559331>
Attachments
Adds WebUserContentURLPattern and WKUserContentURLPattern to WebKit2 (18.42 KB, patch)
2010-10-18 13:52 PDT, Jessie Berlin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jessie Berlin
Comment 1 2010-10-18 13:52:31 PDT
Created attachment 71077 [details] Adds WebUserContentURLPattern and WKUserContentURLPattern to WebKit2
WebKit Review Bot
Comment 2 2010-10-18 13:53:46 PDT
Attachment 71077 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/Shared/API/c/WKUserContentURLPattern.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2010-10-18 14:01:45 PDT
Comment on attachment 71077 [details] Adds WebUserContentURLPattern and WKUserContentURLPattern to WebKit2 You probably need to add the new files to WebKit2.pro as well.
Jessie Berlin
Comment 4 2010-10-18 14:12:10 PDT
(In reply to comment #3) > (From update of attachment 71077 [details]) > You probably need to add the new files to WebKit2.pro as well. Done. Thanks for the review!
Jessie Berlin
Comment 5 2010-10-18 14:33:46 PDT
Comment on attachment 71077 [details] Adds WebUserContentURLPattern and WKUserContentURLPattern to WebKit2 Committed in r69991 http://trac.webkit.org/changeset/69991
Note You need to log in before you can comment on or make changes to this bug.