Summary: | Need a WebKit2 equivalent of the WebKit1 WebUserContentURLPattern | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jessie Berlin <jberlin> | ||||
Component: | WebKit2 | Assignee: | Jessie Berlin <jberlin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aroben, jberlin, sam, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Jessie Berlin
2010-10-17 14:13:23 PDT
Created attachment 71077 [details]
Adds WebUserContentURLPattern and WKUserContentURLPattern to WebKit2
Attachment 71077 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/Shared/API/c/WKUserContentURLPattern.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 71077 [details]
Adds WebUserContentURLPattern and WKUserContentURLPattern to WebKit2
You probably need to add the new files to WebKit2.pro as well.
(In reply to comment #3) > (From update of attachment 71077 [details]) > You probably need to add the new files to WebKit2.pro as well. Done. Thanks for the review! Comment on attachment 71077 [details] Adds WebUserContentURLPattern and WKUserContentURLPattern to WebKit2 Committed in r69991 http://trac.webkit.org/changeset/69991 |