Summary: | Web Inspector: brush up URL parsing on the front-end. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Pavel Feldman
2010-10-16 08:23:26 PDT
Created attachment 70958 [details]
[PATCH] Proposed change.
Created attachment 70959 [details]
[PATCH] Same with layout tests not using old regex.
Comment on attachment 70959 [details] [PATCH] Same with layout tests not using old regex. View in context: https://bugs.webkit.org/attachment.cgi?id=70959&action=review > WebCore/inspector/front-end/utilities.js:396 > +String.prototype.asParsedURL = function() I'd rather make it a function, not a method. > WebCore/inspector/front-end/utilities.js:413 > + return result; You may want to cache result on the String object. Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/inspector/elements-panel-rewrite-href.html M WebCore/ChangeLog M WebCore/inspector/InspectorResource.cpp M WebCore/inspector/front-end/AuditRules.js M WebCore/inspector/front-end/CookieItemsView.js M WebCore/inspector/front-end/DOMAgent.js M WebCore/inspector/front-end/Resource.js M WebCore/inspector/front-end/ResourceCategory.js M WebCore/inspector/front-end/ResourceView.js M WebCore/inspector/front-end/inspector.js M WebCore/inspector/front-end/utilities.js Committed r69947 |