Summary: | Assertion failure in NetscapePlugin::fromNPP when using Shockwave in WebKit2 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
Component: | Plug-ins | Assignee: | Adam Roben (:aroben) <aroben> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, alex, andersca, eric, jhoneycutt, ossy, webkit.review.bot | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
URL: | http://www.nga.gov/kids/zone/dollhouse.htm | ||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2010-10-14 13:44:42 PDT
Created attachment 70777 [details]
Don't require the plugin to always use the same NPP struct we gave it in NPP_New
Attachment 70777 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKitTools/DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:28: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 2 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 70777 [details]
Don't require the plugin to always use the same NPP struct we gave it in NPP_New
Maybe you can make the stylebot slightly happier by reordering #includes?
(In reply to comment #4) > (From update of attachment 70777 [details]) > Maybe you can make the stylebot slightly happier by reordering #includes? I think to make the style bot happy we will have to teach it about the non-standard #include style of these test files. Thanks for reviewing! Committed r70190: <http://trac.webkit.org/changeset/70190> http://trac.webkit.org/changeset/70190 might have broken Qt Linux Release This new test doesn't seem to pass: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r70205%20(19462)/plugins/pass-different-npp-struct-pretty-diff.html I've added this test to the Skipped list for Mac in http://trac.webkit.org/changeset/70213. Can you look into why it's failing? (In reply to comment #9) > I've added this test to the Skipped list for Mac in http://trac.webkit.org/changeset/70213. Can you look into why it's failing? This test is also failing: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug/r70211%20(14993)/plugins/pass-different-npp-struct-pretty-diff.html Skipped in GTK until Adam can review the issue: http://trac.webkit.org/changeset/70215 (In reply to comment #7) > http://trac.webkit.org/changeset/70190 might have broken Qt Linux Release Any progression with fixing? This patch broke the whole world, I don't think if it is a good idea to put this failing test to the skipped list on all platform. (In reply to comment #10) > (In reply to comment #9) > > I've added this test to the Skipped list for Mac in http://trac.webkit.org/changeset/70213. Can you look into why it's failing? > > This test is also failing: > > http://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug/r70211%20(14993)/plugins/pass-different-npp-struct-pretty-diff.html I think PassDifferentNPPStruct.cpp just needs to be added to the GTK build. Sorry about that. (In reply to comment #8) > This new test doesn't seem to pass: > > http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r70205%20(19462)/plugins/pass-different-npp-struct-pretty-diff.html I'm looking into it. (In reply to comment #12) > (In reply to comment #7) > > http://trac.webkit.org/changeset/70190 might have broken Qt Linux Release > > Any progression with fixing? I added PassDifferentNPPStruct.cpp to TestNetscapePlugin.pro in <http://trac.webkit.org/changeset/70196>. I don't know why it's continuing to fail after that. Hopefully I can find a friendly Qt person to help me figure it out. Sorry for the trouble! Fixed GTK and Qt in r70238 and r70242 with help from Andreas and Anders: http://trac.webkit.org/changeset/70238 http://trac.webkit.org/changeset/70242 Unskipped on SnowLeopard after running Software Update on the bots in r70243: http://trac.webkit.org/changeset/70243 |