Bug 47686

Summary: [Chromium] Fix rebaseline_chromium_webkit_tests to use 0 tolerance image diff
Product: WebKit Reporter: Victor Wang <victorw>
Component: Tools / TestsAssignee: Victor Wang <victorw>
Status: RESOLVED FIXED    
Severity: Normal CC: japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Proposed patch japhet: review+

Victor Wang
Reported 2010-10-14 13:35:12 PDT
Rebaseline does not need tolerance for image diff.
Attachments
Proposed patch (1.50 KB, patch)
2010-10-14 13:49 PDT, Victor Wang 		japhet: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Victor Wang
Comment 1 2010-10-14 13:49:06 PDT
Created attachment 70773 [details] Proposed patch
Nate Chapin
Comment 2 2010-10-14 13:51:51 PDT
Comment on attachment 70773 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=70773&action=review > WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:598 > + Remove this extra newline before landing, unless there's a good reason for it that I'm missing :)
Victor Wang
Comment 3 2010-10-14 13:56:47 PDT
Comment on attachment 70773 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=70773&action=review >> WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:598 >> + > > Remove this extra newline before landing, unless there's a good reason for it that I'm missing :) we expect two blank lines here per pep8 style. check-webkit-style script will complain if removed.
Nate Chapin
Comment 4 2010-10-14 13:58:11 PDT
(In reply to comment #3) > (From update of attachment 70773 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=70773&action=review > > >> WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:598 > >> + > > > > Remove this extra newline before landing, unless there's a good reason for it that I'm missing :) > > we expect two blank lines here per pep8 style. check-webkit-style script will complain if removed. That would be a good reason, thanks!
Victor Wang
Comment 5 2010-10-14 14:46:59 PDT
Committed r69806: <http://trac.webkit.org/changeset/69806>
Note You need to log in before you can comment on or make changes to this bug.