Bug 47651

Summary: PlatformMouseEvents need to contain modifier flags
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 245108    
Attachments:
Description Flags
Patch jhoneycutt: review+

Sam Weinig
Reported 2010-10-13 20:54:21 PDT
The PlaformMouseEvent class contains modifier flags in two ways, as bits for the four main fields, and as an unsigned for m_modifierFlags. We don't set m_modifierFlags and thus don't get modifiers sent to us in mouseDidMoveOverElement.
Attachments
Patch (1.24 KB, patch)
2010-10-13 20:57 PDT, Sam Weinig 		jhoneycutt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-10-13 20:57:29 PDT
Created attachment 70707 [details] Patch
Sam Weinig
Comment 2 2010-10-13 21:28:05 PDT
Fixed in http://trac.webkit.org/changeset/69733.
Note You need to log in before you can comment on or make changes to this bug.