Bug 47650

Summary: Make --port a global option and pass the port information to the commit-queue subprocess
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch eric: review+, eric: commit-queue-

Adam Barth
Reported 2010-10-13 20:54:08 PDT
Make --port a global option and pass the port information to the commit-queue subprocess
Attachments
Patch (12.12 KB, patch)
2010-10-13 20:59 PDT, Adam Barth 		eric: review+
eric: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-10-13 20:59:53 PDT
Created attachment 70708 [details] Patch
Eric Seidel (no email)
Comment 2 2010-10-13 21:48:18 PDT
Comment on attachment 70708 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70708&action=review Relatively disgusting. BUt not all your fault. Please fix the above nits. > WebKitTools/Scripts/webkitpy/tool/commands/queues.py:130 > - self.options = options # FIXME: This code is wrong. Command.options is a list, this assumes an Options element! > + self._options = options Please dont' remove this fixme, this code is still WRONG. > WebKitTools/Scripts/webkitpy/tool/commands/queues_unittest.py:87 > + queue._options = Mock() > + queue._options.iterations = 3 Um. Clearly wrong. > WebKitTools/Scripts/webkitpy/tool/commands/queuestest.py:83 > + def assert_queue_outputs(self, queue, args=None, work_item=None, expected_stdout=None, expected_stderr=None, expected_exceptions=None, options=None, tool=MockTool()): setting tool=MockTool() is wrong here. That will share an instance of MockTool() for all callers!
Adam Barth
Comment 3 2010-10-13 22:05:01 PDT
Committed r69737: <http://trac.webkit.org/changeset/69737>
Note You need to log in before you can comment on or make changes to this bug.