Summary: | Conversion to text test: editing/spelling/spellcheck-attribute.html | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hajime Morrita <morrita> | ||||||
Component: | Tools / Tests | Assignee: | Hajime Morrita <morrita> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, eric, rniwa, tkent, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | 47659 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Hajime Morrita
2010-10-13 19:14:59 PDT
Created attachment 70705 [details]
Patch
Comment on attachment 70705 [details]
Patch
ok
> LayoutTests/editing/spelling/spellcheck-attribute.html:37
> + if (window.textInputController) {
> + var marked = (0 != textInputController.hasSpellingMarker(0, 2));
> + if (shouldMarked == marked)
> + log("PASS:" + id);
> + else
> + log("FAIL:" + id);
> + }
This would fail on all platforms that do not implement textInputController. Are you sure all platforms that currently run this test implement textInputController? We can't do this conversion if the answer is no because we'll be losing the test coverage then.
Comment on attachment 70705 [details]
Patch
win/gtk/qt has no textInputController.hasSpelingMarkers(), and we should remove expectation images for Chromium, and so on.
(In reply to comment #3) > This would fail on all platforms that do not implement textInputController. Are you sure all platforms that currently run this test implement textInputController? We can't do this conversion if the answer is no because we'll be losing the test coverage then. GTK and Qt is skipping this test. So we can convert this if Windows port gets textInputController.hasSpellingMarkers(). (In reply to comment #1) > Created an attachment (id=70705) [details] > Patch You might find my script posted on https://bugs.webkit.org/show_bug.cgi?id=45100 useful. It lets you delete all png, checksum, etc... under LayoutTest/platform/ (In reply to comment #6) > You might find my script posted on https://bugs.webkit.org/show_bug.cgi?id=45100 useful. It lets you delete all png, checksum, etc... under LayoutTest/platform/ Thanks! I didn't noticed this. Created attachment 71534 [details]
Patch
> GTK and Qt is skipping this test. So we can convert this if Windows port gets textInputController.hasSpellingMarkers(). Landed Bug 47885. It's time to make this happen! I'm working on Bug 25539 and planning extend this test for that. So landing this early would be helpful. Comment on attachment 71534 [details]
Patch
Looks good!
Committed r70295: <http://trac.webkit.org/changeset/70295> http://trac.webkit.org/changeset/70295 might have broken GTK Linux 64-bit Debug |