Conversion to text test: editing/spelling/spellcheck-attribute.html

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Hajime Morrita]

Should convert a pixel test to text based test.

[Hajime Morrita]

Created attachment 70705 [details]
Patch

[Kent Tamura]

Comment on attachment 70705 [details]
Patch

ok

[Ryosuke Niwa]

> LayoutTests/editing/spelling/spellcheck-attribute.html:37
> +    if (window.textInputController) {
> +        var marked = (0 != textInputController.hasSpellingMarker(0, 2));
> +        if (shouldMarked == marked)
> +           log("PASS:" + id);
> +        else
> +           log("FAIL:" + id);
> +    }

This would fail on all platforms that do not implement textInputController.  Are you sure all platforms that currently run this test implement textInputController?  We can't do this conversion if the answer is no because we'll be losing the test coverage then.

[Kent Tamura]

Comment on attachment 70705 [details]
Patch

win/gtk/qt has no textInputController.hasSpelingMarkers(), and we should remove expectation images for Chromium, and so on.

[Kent Tamura]

(In reply to comment #3)
> This would fail on all platforms that do not implement textInputController.  Are you sure all platforms that currently run this test implement textInputController?  We can't do this conversion if the answer is no because we'll be losing the test coverage then.

GTK and Qt is skipping this test.  So we can convert this if Windows port gets textInputController.hasSpellingMarkers().

[Ryosuke Niwa]

(In reply to comment #1)
> Created an attachment (id=70705) [details]
> Patch

You might find my script posted on https://bugs.webkit.org/show_bug.cgi?id=45100 useful.  It lets you delete all png, checksum, etc... under LayoutTest/platform/

[Hajime Morrita]

(In reply to comment #6)
> You might find my script posted on https://bugs.webkit.org/show_bug.cgi?id=45100 useful.  It lets you delete all png, checksum, etc... under LayoutTest/platform/
Thanks! I didn't noticed this.

[Hajime Morrita]

Created attachment 71534 [details]
Patch

[Hajime Morrita]

> GTK and Qt is skipping this test.  So we can convert this if Windows port gets textInputController.hasSpellingMarkers().
Landed Bug 47885. It's time to make this happen!
I'm working on Bug 25539 and planning extend this test for that.
So landing this early would be helpful.

[Kent Tamura]

Comment on attachment 71534 [details]
Patch

Looks good!

[Hajime Morrita]

Committed r70295: <http://trac.webkit.org/changeset/70295>

[WebKit Review Bot]

http://trac.webkit.org/changeset/70295 might have broken GTK Linux 64-bit Debug