Bug 47635

Summary: Add a FindIndicator class
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch sam: review+

Description Anders Carlsson 2010-10-13 16:27:54 PDT
Add a FindIndicator class
Comment 1 Anders Carlsson 2010-10-13 17:14:11 PDT
Created attachment 70687 [details]
Patch
Comment 2 WebKit Review Bot 2010-10-13 17:16:57 PDT
Attachment 70687 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/FindIndicator.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/UIProcess/FindIndicator.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 2 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2010-10-15 10:27:54 PDT
Committed r69862: <http://trac.webkit.org/changeset/69862>