Summary: | [GTK] r69681 caused some tests to crash | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | alex, gustavo, zecke | ||||||||
Priority: | P3 | Keywords: | Gtk | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Linux | ||||||||||
Attachments: |
|
Description
Martin Robinson
2010-10-13 14:29:03 PDT
Created attachment 70662 [details]
Relavent stack trace
Created attachment 70664 [details]
Patch for this issue
I think you should initialize m_layerContext in the ctor, then this null check will work. Created attachment 70670 [details]
Patch with Holger's suggestion
Comment on attachment 70670 [details]
Patch with Holger's suggestion
Looks good, Qt EWS is green too.
Committed r69701: <http://trac.webkit.org/changeset/69701> |