Bug 47622

Summary: [GTK] r69681 caused some tests to crash
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, gustavo, zecke
Priority: P3 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Relavent stack trace
none
Patch for this issue
none
Patch with Holger's suggestion zecke: review+

Description Martin Robinson 2010-10-13 14:29:03 PDT
Before landing this patch did not cause tests to crash locally. It was only after this patch landed were any problems detected.
Comment 1 Martin Robinson 2010-10-13 14:29:45 PDT
Created attachment 70662 [details]
Relavent stack trace
Comment 2 Martin Robinson 2010-10-13 14:34:44 PDT
Created attachment 70664 [details]
Patch for this issue
Comment 3 Holger Freyther 2010-10-13 15:08:41 PDT
I think you should initialize m_layerContext in the ctor, then this null check will work.
Comment 4 Martin Robinson 2010-10-13 15:12:47 PDT
Created attachment 70670 [details]
Patch with Holger's suggestion
Comment 5 Holger Freyther 2010-10-13 15:18:08 PDT
Comment on attachment 70670 [details]
Patch with Holger's suggestion

Looks good, Qt EWS is green too.
Comment 6 Martin Robinson 2010-10-13 15:25:22 PDT
Committed r69701: <http://trac.webkit.org/changeset/69701>