Bug 47610

Summary: Revert changes to WebViewImpl in r69633
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebKit Misc.Assignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch jamesr: review+, kbr: commit-queue-

Kenneth Russell
Reported 2010-10-13 11:50:06 PDT
David Levin pointed out that the change to WebViewImpl in http://trac.webkit.org/changeset/69633 incorrectly used PassRefPtr for a local variable instead of RefPtr. I thought I had seen an assertion failure in this code change in http://trac.webkit.org/changeset/69624 but after reverting it it seems not.
Attachments
Patch (1.88 KB, patch)
2010-10-13 11:51 PDT, Kenneth Russell 		jamesr: review+
kbr: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2010-10-13 11:51:52 PDT
Created attachment 70643 [details] Patch
James Robinson
Comment 2 2010-10-13 12:01:18 PDT
Comment on attachment 70643 [details] Patch Yup!
Kenneth Russell
Comment 3 2010-10-13 13:30:15 PDT
Committed r69693: <http://trac.webkit.org/changeset/69693>
Note You need to log in before you can comment on or make changes to this bug.