Bug 47597

Summary:

Proposal: Require cross-organizational seconds for reviewer nominations

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, darin, hamaji, kenneth, kling, mjs, tonikitoo

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	darin: review+

Eric Seidel (no email)

Reported 2010-10-13 09:49:16 PDT

Proposal: Require cross-organizational seconds for reviewer nominations

Attachments
Patch (2.46 KB, patch) 2010-10-13 09:55 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Patch (2.82 KB, patch) 2010-10-13 09:58 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Patch (3.03 KB, patch) 2011-01-13 11:13 PST, David Levin	no flags	Details Formatted Diff Diff
Patch (3.04 KB, patch) 2011-01-13 15:25 PST, David Levin	darin: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2010-10-13 09:55:38 PDT

Created attachment 70619 [details] Patch

Eric Seidel (no email)

Comment 2 2010-10-13 09:58:21 PDT

Created attachment 70620 [details] Patch

Kenneth Rohde Christiansen

Comment 3 2010-12-24 02:44:19 PST

Comment on attachment 70620 [details] Patch I do not know who could review this, thought I support it. Did we agree on this on the mailing list?

Eric Seidel (no email)

Comment 4 2010-12-24 08:33:14 PST

I'm not as passionate about this patch as a once was. But I still think it's a good idea.

Antonio Gomes

Comment 5 2010-12-24 09:00:30 PST

I do not think this patch should be up for review until there is a 100% agreement on the mailing list. ps: I agree with it. Well, sorta ... sometimes it is unneeded, you know...

Darin Adler

Comment 6 2010-12-24 09:50:43 PST

Comment on attachment 70620 [details] Patch This should be discussed on the reviewer mailing list. I don’t think the patch review process is sufficient for changing the rules about becoming a reviewer.

Adam Barth

Comment 7 2011-01-12 16:39:06 PST

Comment on attachment 70620 [details] Patch There's been some discussion of this change on the webkit-reviewers list. I'm not sure this patch reflects the current consensus. In any case, we should probably sort out what policy we want first.

David Levin

Comment 8 2011-01-13 11:13:00 PST

Created attachment 78830 [details] Patch

Eric Seidel (no email)

Comment 9 2011-01-13 12:27:32 PST

Thanks dave!

David Levin

Comment 10 2011-01-13 15:25:24 PST

Created attachment 78863 [details] Patch

Darin Adler

Comment 11 2011-01-21 11:00:19 PST

Comment on attachment 78863 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78863&action=review OK. Lets do this. My grammatical tweak suggestions are not binding, of course. For one thing they haven’t even been discussed with the rest of the reviewers. > Websites/webkit.org/coding/commit-review-policy.html:102 > +community as a whole, and not just within their own place of employment or This comma should be removed. > Websites/webkit.org/coding/commit-review-policy.html:105 > +with the nominee (other than WebKit itself).</p> This would be better with a comma rather than parentheses. I also think "the WebKit project itself" would be clearer than "WebKit itself".

Eric Seidel (no email)

Comment 12 2011-01-21 12:35:49 PST

http://trac.webkit.org/changeset/76367

Note You need to log in before you can comment on or make changes to this bug.