Summary: | Proposal: Require cross-organizational seconds for reviewer nominations | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||||||
Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ap, darin, hamaji, kenneth, kling, mjs, tonikitoo | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Other | ||||||||||||
OS: | OS X 10.5 | ||||||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2010-10-13 09:49:16 PDT
Created attachment 70619 [details]
Patch
Created attachment 70620 [details]
Patch
Comment on attachment 70620 [details]
Patch
I do not know who could review this, thought I support it. Did we agree on this on the mailing list?
I'm not as passionate about this patch as a once was. But I still think it's a good idea. I do not think this patch should be up for review until there is a 100% agreement on the mailing list. ps: I agree with it. Well, sorta ... sometimes it is unneeded, you know... Comment on attachment 70620 [details]
Patch
This should be discussed on the reviewer mailing list. I don’t think the patch review process is sufficient for changing the rules about becoming a reviewer.
Comment on attachment 70620 [details]
Patch
There's been some discussion of this change on the webkit-reviewers list. I'm not sure this patch reflects the current consensus. In any case, we should probably sort out what policy we want first.
Created attachment 78830 [details]
Patch
Thanks dave! Created attachment 78863 [details]
Patch
Comment on attachment 78863 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78863&action=review OK. Lets do this. My grammatical tweak suggestions are not binding, of course. For one thing they haven’t even been discussed with the rest of the reviewers. > Websites/webkit.org/coding/commit-review-policy.html:102 > +community as a whole, and not just within their own place of employment or This comma should be removed. > Websites/webkit.org/coding/commit-review-policy.html:105 > +with the nominee (other than WebKit itself).</p> This would be better with a comma rather than parentheses. I also think "the WebKit project itself" would be clearer than "WebKit itself". |