Bug 4757

Summary:

leaks found by code inspection in apply-style command

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

HTML Editing

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
patch to fix the leaks I spotted	none
patch revised to use SharedPtr as per Maciej's suggestion	mjs: review+

Description Darin Adler 2005-08-30 10:47:13 PDT

Comment 1 Darin Adler 2005-08-30 10:48:18 PDT

Created attachment 3675 [details]
patch to fix the leaks I spotted

Comment 2 Darin Adler 2005-08-31 00:31:31 PDT

Comment on attachment 3675 [details]
patch to fix the leaks I spotted

I have no tests, but still probably should get this reviewed.

Comment 3 Maciej Stachowiak 2005-08-31 02:10:03 PDT

Comment on attachment 3675 [details]
patch to fix the leaks I spotted

Perhaps it would be better to store the CSSValueImpls in a SharedPtr instead of
doing the ref()/deref() pair manually.

Comment 4 Darin Adler 2005-09-01 09:35:56 PDT

Created attachment 3710 [details]
patch revised to use SharedPtr as per Maciej's suggestion

Comment 5 Maciej Stachowiak 2005-09-02 02:49:02 PDT

Comment on attachment 3710 [details]
patch revised to use SharedPtr as per Maciej's suggestion

r=me