Bug 4757

Summary: leaks found by code inspection in apply-style command
Product: WebKit Reporter: Darin Adler <darin>
Component: HTML EditingAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch to fix the leaks I spotted
none
patch revised to use SharedPtr as per Maciej's suggestion mjs: review+

Darin Adler
Reported 2005-08-30 10:47:13 PDT
Attachments
patch to fix the leaks I spotted (4.71 KB, patch)
2005-08-30 10:48 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
patch revised to use SharedPtr as per Maciej's suggestion (14.58 KB, patch)
2005-09-01 09:35 PDT, Darin Adler 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2005-08-30 10:48:18 PDT
Created attachment 3675 [details] patch to fix the leaks I spotted
Darin Adler
Comment 2 2005-08-31 00:31:31 PDT
Comment on attachment 3675 [details] patch to fix the leaks I spotted I have no tests, but still probably should get this reviewed.
Maciej Stachowiak
Comment 3 2005-08-31 02:10:03 PDT
Comment on attachment 3675 [details] patch to fix the leaks I spotted Perhaps it would be better to store the CSSValueImpls in a SharedPtr instead of doing the ref()/deref() pair manually.
Darin Adler
Comment 4 2005-09-01 09:35:56 PDT
Created attachment 3710 [details] patch revised to use SharedPtr as per Maciej's suggestion
Maciej Stachowiak
Comment 5 2005-09-02 02:49:02 PDT
Comment on attachment 3710 [details] patch revised to use SharedPtr as per Maciej's suggestion r=me
Note You need to log in before you can comment on or make changes to this bug.