Bug 47568

Summary: Update getUniform for bvec[234] to return boolean[] rather than Uint8Array
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, enne, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch kbr: review+, zmo: commit-queue-

Kenneth Russell
Reported 2010-10-12 18:47:30 PDT
In a recent WebGL working group face-to-face it was decided to change getUniform for bvec[234] to return boolean[] rather than Uint8Array. The WebGL implementation and any associated tests need to be updated.
Attachments
patch (4.84 KB, patch)
2010-10-28 17:15 PDT, Zhenyao Mo 		kbr: review+
zmo: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zhenyao Mo
Comment 1 2010-10-28 17:15:21 PDT
Created attachment 72266 [details] patch Test has been updated on the khronos already.
Kenneth Russell
Comment 2 2010-11-02 11:37:25 PDT
Comment on attachment 72266 [details] patch Looks good.
Zhenyao Mo
Comment 3 2010-11-02 14:02:09 PDT
Committed r71164: <http://trac.webkit.org/changeset/71164>
Note You need to log in before you can comment on or make changes to this bug.