Bug 47555

Summary: Add FindController class
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch sam: review+

Anders Carlsson
Reported 2010-10-12 13:43:15 PDT
Add FindController class
Attachments
Patch (16.82 KB, patch)
2010-10-12 13:47 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-10-12 13:47:52 PDT
Created attachment 70561 [details] Patch
WebKit Review Bot
Comment 2 2010-10-12 13:50:57 PDT
Attachment 70561 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/WebPage/FindController.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/WebProcess/WebPage/FindController.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2010-10-12 14:01:45 PDT
Committed r69598: <http://trac.webkit.org/changeset/69598>
Note You need to log in before you can comment on or make changes to this bug.