Bug 47552

Summary:

Make TestWebKitAPI work on Windows

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Tools / Tests

Assignee:

Adam Roben (:aroben) <aroben>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

sam, webkit.review.bot

Priority:

Keywords:

InRadar, PlatformOnly

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
Make TestWebKitAPI work on Windows	sam: review+

Description Adam Roben (:aroben) 2010-10-12 12:19:42 PDT

We should make TestWebKitAPI work on Windows.

Comment 1 Adam Roben (:aroben) 2010-10-12 12:20:32 PDT

<rdar://problem/8541708>

Comment 2 Adam Roben (:aroben) 2010-10-12 12:34:33 PDT

Created attachment 70555 [details]
Make TestWebKitAPI work on Windows

Comment 3 WebKit Review Bot 2010-10-12 12:35:25 PDT

Attachment 70555 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/TestWebKitAPI/win/PlatformWebViewWin.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/TestWebKitAPI/TestWebKitAPIPrefix.h:41:  Alphabetical sorting problem.  [build/include_order] [4]
WebKitTools/TestWebKitAPI/win/main.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 4 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Adam Roben (:aroben) 2010-10-13 07:00:35 PDT

Committed r69656: <http://trac.webkit.org/changeset/69656>