Summary: | Web Inspector: need a breakpoint for the timer events. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ilya Tikhonovsky <loislo> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, podivilov, rik, timothy, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Ilya Tikhonovsky
2010-10-12 05:48:30 PDT
Created attachment 70600 [details]
Patch.
Comment on attachment 70600 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=70600&action=review > WebCore/inspector/InspectorInstrumentation.cpp:46 > +static const char* const timeoutEventName = "extended.timeout"; "timeout" is a bad name for the event. timerFire (localized "Timer fire" in UI) sounds more user-friendly. Also, encoding extended event names using dot-separated strings is fragile: there is no guarantee event will not have similar name. So you should either create a pair here or be more creative about encoding the event names. > WebCore/inspector/front-end/BreakpointManager.js:508 > + if (this._eventName.search(prefix) !== 0) Nit: use indexOf instead of regex search. > WebCore/inspector/front-end/BreakpointsSidebarPane.js:251 > + "HTML frame/object": ["load", "error", "resize", "scroll", "extended.timeout"] I think you are adding confusion here: timeout is not a real event. I think we should we have a separate category for it. It might have all timer-related breaks such as setTimeout, clearTimeout and timerFire event. > > WebCore/inspector/front-end/BreakpointsSidebarPane.js:251
> > + "HTML frame/object": ["load", "error", "resize", "scroll", "extended.timeout"]
>
> I think you are adding confusion here: timeout is not a real event. I think we should we have a separate category for it. It might have all timer-related breaks such as setTimeout, clearTimeout and timerFire event.
+1
Created attachment 70609 [details]
[IMAGE] Unified breakpoints design mock.
it'd be interesting to have separate checkboxes for tracking send request/receive response for xhr The same idea for DOM modifications. Just have separate checkboxes for add/modify/delete. Created attachment 70721 [details]
Comments addressed.
Comment on attachment 70721 [details]
Comments addressed.
Please do not forget to land localizedStrings.
Commited in http://trac.webkit.org/changeset/69760. |