Bug 47540

Summary: [Qt] Update .def file for Symbian
Product: WebKit Reporter: Dinu Jacob <dinu.jacob>
Component: New BugsAssignee: Dinu Jacob <dinu.jacob>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar, commit-queue, cshu
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: S60 3rd edition   
Attachments:
Description Flags
Patch
none
Patch
none
Path with merge conflicts fixed none

Description Dinu Jacob 2010-10-12 04:18:47 PDT 
The def file for Symbian is out of date.
API QWebPage::viewportConfigurationForSize  has been replaced by QWebPage::viewportAttributesForSize. Hence, the def file should be updated.
Comment 1 Dinu Jacob 2010-10-12 08:42:24 PDT 
Created attachment 70532 [details]
Patch
Comment 2 Dinu Jacob 2010-10-12 08:43:25 PDT 
Created attachment 70533 [details]
Patch
Comment 3 WebKit Commit Bot 2010-10-12 09:45:53 PDT 
Comment on attachment 70533 [details]
Patch 

Rejecting patch 70533 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 70533]" exit_code: 2
Cleaning working directory
Updating working directory
Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=70533&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=47540&ctype=xml
Processing 1 patch from 1 bug.
Processing patch 70533 from bug 47540.
Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/4353029
Comment 4 Dinu Jacob 2010-10-13 04:37:13 PDT 
Created attachment 70598 [details]
Path with merge conflicts fixed
Comment 5 Andreas Kling 2010-10-13 04:40:25 PDT 
Comment on attachment 70598 [details]
Path with merge conflicts fixed

lgtm
Comment 6 WebKit Commit Bot 2010-10-13 04:56:22 PDT 
Comment on attachment 70598 [details]
Path with merge conflicts fixed

Clearing flags on attachment: 70598

Committed r69648: <http://trac.webkit.org/changeset/69648>
Comment 7 WebKit Commit Bot 2010-10-13 04:56:27 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Ademar Reis 2010-10-15 07:19:26 PDT 
Revision r69648 cherry-picked into qtwebkit-2.1 with commit e90c2b2 <http://gitorious.org/webkit/qtwebkit/commit/e90c2b2>