Bug 47540

Summary:

[Qt] Update .def file for Symbian

Product:

WebKit

Reporter:

Dinu Jacob <dinu.jacob>

Component:

New Bugs

Assignee:

Dinu Jacob <dinu.jacob>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ademar, commit-queue, cshu

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

S60 3rd edition

Attachments:

Description	Flags
Patch	none
Patch	none
Path with merge conflicts fixed	none

Dinu Jacob

Reported 2010-10-12 04:18:47 PDT

The def file for Symbian is out of date. API QWebPage::viewportConfigurationForSize has been replaced by QWebPage::viewportAttributesForSize. Hence, the def file should be updated.

Attachments
Patch (1.28 KB, patch) 2010-10-12 08:42 PDT, Dinu Jacob	no flags	Details Formatted Diff Diff
Patch (1.28 KB, patch) 2010-10-12 08:43 PDT, Dinu Jacob	no flags	Details Formatted Diff Diff
Path with merge conflicts fixed (1.48 KB, patch) 2010-10-13 04:37 PDT, Dinu Jacob	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Dinu Jacob

Comment 1 2010-10-12 08:42:24 PDT

Created attachment 70532 [details] Patch

Dinu Jacob

Comment 2 2010-10-12 08:43:25 PDT

Created attachment 70533 [details] Patch

WebKit Commit Bot

Comment 3 2010-10-12 09:45:53 PDT

Comment on attachment 70533 [details] Patch Rejecting patch 70533 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 70533]" exit_code: 2 Cleaning working directory Updating working directory Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=70533&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=47540&ctype=xml Processing 1 patch from 1 bug. Processing patch 70533 from bug 47540. Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/4353029

Dinu Jacob

Comment 4 2010-10-13 04:37:13 PDT

Created attachment 70598 [details] Path with merge conflicts fixed

Andreas Kling

Comment 5 2010-10-13 04:40:25 PDT

Comment on attachment 70598 [details] Path with merge conflicts fixed lgtm

WebKit Commit Bot

Comment 6 2010-10-13 04:56:22 PDT

Comment on attachment 70598 [details] Path with merge conflicts fixed Clearing flags on attachment: 70598 Committed r69648: <http://trac.webkit.org/changeset/69648>

WebKit Commit Bot

Comment 7 2010-10-13 04:56:27 PDT

All reviewed patches have been landed. Closing bug.

Ademar Reis

Comment 8 2010-10-15 07:19:26 PDT

Revision r69648 cherry-picked into qtwebkit-2.1 with commit e90c2b2 <http://gitorious.org/webkit/qtwebkit/commit/e90c2b2>

Note You need to log in before you can comment on or make changes to this bug.