Bug 47503

Summary: [GTK] Cleanup font selection code for the Freetype backend
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, gustavo, webkit.review.bot
Priority: P3 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Cleanup patch gustavo: review+

Description Martin Robinson 2010-10-11 14:30:12 PDT
There are some issues with the font selection code for the Freetype backend:

1. It does not allow fallback behavior for 'cursive' and 'fantasy' fonts.
2. The synthetic oblique tests is missing some necessary fonts.conf settings, and thus has an incorrect baseline.
3. There is a large block comment originating from an Apache licensed file in the Skia project which should be removed.

I think these changes are related enough to be combined into one patch.
Comment 1 Martin Robinson 2010-10-11 14:43:12 PDT
Created attachment 70475 [details]
Cleanup patch
Comment 2 Gustavo Noronha (kov) 2010-10-11 14:50:22 PDT
Comment on attachment 70475 [details]
Cleanup patch

Great!
Comment 3 Martin Robinson 2010-10-11 15:04:45 PDT
Committed r69528: <http://trac.webkit.org/changeset/69528>
Comment 4 WebKit Review Bot 2010-10-11 15:45:13 PDT
http://trac.webkit.org/changeset/69528 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
editing/selection/move-past-trailing-space.html
fast/css/shadow-multiple.html
fast/text/shadow-no-blur.html