Summary: | fast/viewport/viewport-45.html fails in GTK+/Qt | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joone Hur <joone> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ademar, benjamin, cmarcelo, commit-queue, igor.oliveira, kenneth, webkit.review.bot, xan.lopez | ||||
Priority: | P2 | Keywords: | LayoutTestFailure, Qt, QtTriaged | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Joone Hur
2010-10-10 23:43:40 PDT
Here are the expected results from Opera. fast/viewport/viewport-6.html Expected values: width=200, height=220, initial-scale=1.6 fast/viewport/viewport-45.html Expected values: width=3200, height=3520, initial-scale=0.1 fast/viewport/viewport-58.html Expected values: width=3200, height=3520, initial-scale=0.1 Reproduced with r79438 and Qt 4.7.1 in the tester virtual machine http://webkit.sed.hu/blog/20101028/qtwebkit-builder-and-tester-virtual-machine Curiously, in my Linux 64bits and Qt 4.7.x the three tests pass. ...my Linux 64bits and Qt 4.7.x and QtWebKit from trunk... Created attachment 95670 [details]
Patch
Proposed patch.
Comment on attachment 95670 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95670&action=review > LayoutTests/fast/viewport/viewport-86-expected.txt:1 > -viewport size 457x502 scale 0.700000 with limits [0.700000, 5.000000] and userScalable -1.000000 > +viewport size 457x503 scale 0.700000 with limits [0.700000, 5.000000] and userScalable -1.000000 Is this correct in comparison with other platforms? Yeah, Just gtk is testing viewport tag and it works with the new expected result. (In reply to comment #5) > (From update of attachment 95670 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=95670&action=review > > > LayoutTests/fast/viewport/viewport-86-expected.txt:1 > > -viewport size 457x502 scale 0.700000 with limits [0.700000, 5.000000] and userScalable -1.000000 > > +viewport size 457x503 scale 0.700000 with limits [0.700000, 5.000000] and userScalable -1.000000 > > Is this correct in comparison with other platforms? Comment on attachment 95670 [details] Patch Clearing flags on attachment: 95670 Committed r88134: <http://trac.webkit.org/changeset/88134> All reviewed patches have been landed. Closing bug. Revision r88134 cherry-picked into qtwebkit-2.2 with commit b1708ec <http://gitorious.org/webkit/qtwebkit/commit/b1708ec> |