Bug 47470

Summary:

[cairo] Typo in determining fixed width fonts

Product:

WebKit

Reporter:

Holger Freyther <zecke>

Component:

WebCore Misc.

Assignee:

Holger Freyther <zecke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, mrobinson

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Attempt to fix it...	mrobinson: review+

Holger Freyther

Reported 2010-10-10 10:12:59 PDT

FontPlatformDataFreeType.cpp appears to have a thinko. It is mostly meant to use a '&' instead of a '&&' or otherwise the the whole '&& Constant' is not needed.

Attachments
Attempt to fix it... (2.06 KB, patch) 2010-10-10 10:17 PDT, Holger Freyther	mrobinson: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Holger Freyther

Comment 1 2010-10-10 10:17:14 PDT

Created attachment 70408 [details] Attempt to fix it... The patch most likely requires fixes to the test results.

Martin Robinson

Comment 2 2010-10-13 12:03:42 PDT

This fix does not seem to change any test results which is somewhat worrying. The fix is obvious right to me, so I'm going to r+ it, but in the future it might be good to check if this code can be removed. I notice that isFixedPitch is notImplemented in Chromium.

Martin Robinson

Comment 3 2010-10-13 12:04:06 PDT

Comment on attachment 70408 [details] Attempt to fix it... Thanks for finding this.

Eric Seidel (no email)

Comment 4 2010-10-13 12:27:58 PDT

Attachment 70408 [details] was posted by a committer and has review+, assigning to Holger Freyther for commit.

Holger Freyther

Comment 5 2010-10-14 10:25:01 PDT

Landed in r69776.

Note You need to log in before you can comment on or make changes to this bug.