Bug 47456

Summary: Exception in committers-autocomplete in Firefox
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: abarth, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
Patch none

Description Alexey Proskuryakov 2010-10-09 13:56:52 PDT
Steps to reproduce: open any b.w.o bug in Firefox. Not sure if you need to be logged in.

Missing last argument in addEventListener at line 387.
Comment 1 Adam Barth 2010-10-09 19:43:01 PDT
Should be an easy patch.
Comment 2 Adam Barth 2010-10-09 19:47:57 PDT
Created attachment 70383 [details]
Comment 3 Alexey Proskuryakov 2010-10-09 20:45:05 PDT
Comment on attachment 70383 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=70383&action=review

> BugsSite/ChangeLog:10
> +        Remove dependency on a WebKit-only quirk.  IMHO, this quirk is bad for
> +        the long-term health of the web, but that's a discussion for another
> +        patch.

This has been discussed before. Requiring that useless arguments are passed explicitly is also not super great.
Comment 4 WebKit Commit Bot 2010-10-09 21:17:16 PDT
Comment on attachment 70383 [details]

Clearing flags on attachment: 70383

Committed r69464: <http://trac.webkit.org/changeset/69464>
Comment 5 WebKit Commit Bot 2010-10-09 21:17:21 PDT
All reviewed patches have been landed.  Closing bug.