Bug 47456

Summary: Exception in committers-autocomplete in Firefox
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Alexey Proskuryakov
Reported 2010-10-09 13:56:52 PDT
Steps to reproduce: open any b.w.o bug in Firefox. Not sure if you need to be logged in. Missing last argument in addEventListener at line 387.
Attachments
Patch (2.33 KB, patch)
2010-10-09 19:47 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-10-09 19:43:01 PDT
Should be an easy patch.
Adam Barth
Comment 2 2010-10-09 19:47:57 PDT
Created attachment 70383 [details] Patch
Alexey Proskuryakov
Comment 3 2010-10-09 20:45:05 PDT
Comment on attachment 70383 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70383&action=review > BugsSite/ChangeLog:10 > + Remove dependency on a WebKit-only quirk. IMHO, this quirk is bad for > + the long-term health of the web, but that's a discussion for another > + patch. This has been discussed before. Requiring that useless arguments are passed explicitly is also not super great.
WebKit Commit Bot
Comment 4 2010-10-09 21:17:16 PDT
Comment on attachment 70383 [details] Patch Clearing flags on attachment: 70383 Committed r69464: <http://trac.webkit.org/changeset/69464>
WebKit Commit Bot
Comment 5 2010-10-09 21:17:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.