Bug 47438

Summary: webkit-patch build shouldn't need --build to actually build!
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2010-10-08 16:27:54 PDT
webkit-patch build shouldn't need --build to actually build!
Attachments
Patch (10.69 KB, patch)
2010-10-08 16:30 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-10-08 16:30:32 PDT
Created attachment 70313 [details] Patch
WebKit Commit Bot
Comment 2 2010-10-13 10:23:59 PDT
Comment on attachment 70313 [details] Patch Rejecting patch 70313 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--quiet', '--non-interactive']" exit_code: 2 Last 500 characters of output: 0.11 usr 0.07 sys + 0.66 cusr 0.20 csys = 1.04 CPU) Result: PASS Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 21244 test cases. fast/workers/storage/interrupt-database-sync.html -> failed Exiting early after 1 failures. 15725 tests run. 537.64s total testing time 15724 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 9 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/4420006
Adam Barth
Comment 3 2010-10-13 10:24:37 PDT
Comment on attachment 70313 [details] Patch sigh
WebKit Commit Bot
Comment 4 2010-10-13 12:54:25 PDT
Comment on attachment 70313 [details] Patch Clearing flags on attachment: 70313 Committed r69685: <http://trac.webkit.org/changeset/69685>
WebKit Commit Bot
Comment 5 2010-10-13 12:54:30 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2010-10-13 14:06:10 PDT
http://trac.webkit.org/changeset/69685 might have broken Chromium Mac Release
Note You need to log in before you can comment on or make changes to this bug.