Bug 47437

Summary: Add File API feature guard to all typed array files
Product: WebKit Reporter: Jian Li <jianli>
Component: WebCore JavaScriptAssignee: Jian Li <jianli>
Status: RESOLVED FIXED    
Severity: Normal CC: dimich, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Proposed Patch abarth: review+, jianli: commit-queue-

Jian Li
Reported 2010-10-08 16:09:20 PDT
Currently typed array is guarded with 3D_CANVAS. Since it will be used in FileReader and BlobBuilder, we need to change all related files to append File API feature guard.
Attachments
Proposed Patch (9.62 KB, patch)
2010-10-08 16:14 PDT, Jian Li 		abarth: review+
jianli: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jian Li
Comment 1 2010-10-08 16:14:23 PDT
Created attachment 70311 [details] Proposed Patch
Adam Barth
Comment 2 2010-10-10 12:25:49 PDT
I forget how the webkit-dev thread on this topic went.
Jian Li
Comment 3 2010-10-11 11:31:13 PDT
(In reply to comment #2) > I forget how the webkit-dev thread on this topic went. I think we agree to append a feature guard until ArrayBuffer is used in XHR. https://lists.webkit.org/pipermail/webkit-dev/2010-October/014716.html
Adam Barth
Comment 4 2010-10-11 11:49:07 PDT
Comment on attachment 70311 [details] Proposed Patch great, thanks for the link. Maybe add that information to the change log for easy reference in the future?
Jian Li
Comment 5 2010-10-11 13:17:44 PDT
Updated ChangeLog as suggested and committed as http://trac.webkit.org/changeset/69520.
Note You need to log in before you can comment on or make changes to this bug.