Bug 47408

Summary: Pages using DeviceOrientation and DeviceMotion should not go into the page cache
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson, commit-queue, mitz, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 30335    
Attachments:
Description Flags
Patch none

Description Steve Block 2010-10-08 04:14:08 PDT
The controllers for DeviceOrientation and DeviceMotion stop the client when all listeners are removed. We want the client to be stopped as soon as the page is navigated away, but listeners are not removed if the page goes into the page cache. Therefore, we should prevent documents using DeviceOrientation and DeviceMotion from entering the page cache.
Comment 1 Steve Block 2010-10-08 04:17:55 PDT
Created attachment 70225 [details]
Patch
Comment 2 Alexey Proskuryakov 2010-10-08 11:23:39 PDT
Long term, we want such pages to stay in page cache, right?
Comment 3 Steve Block 2010-10-08 11:40:04 PDT
> Long term, we want such pages to stay in page cache, right?
Yes, that's probably true.
Comment 4 Steve Block 2010-10-12 00:43:38 PDT
Alexey, would you be able to review?
Comment 5 Alexey Proskuryakov 2010-10-12 14:16:51 PDT
Comment on attachment 70225 [details]
Patch

Loks sane, except for the part where test code is in a separate .js file.
Comment 6 WebKit Commit Bot 2010-10-13 03:00:46 PDT
Comment on attachment 70225 [details]
Patch

Clearing flags on attachment: 70225

Committed r69646: <http://trac.webkit.org/changeset/69646>
Comment 7 WebKit Commit Bot 2010-10-13 03:00:53 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 mitz 2010-10-13 08:17:27 PDT
(In reply to comment #3)
> > Long term, we want such pages to stay in page cache, right?
> Yes, that's probably true.

Has a bug been filed to track this?
Comment 9 Steve Block 2010-10-14 07:16:27 PDT
> Has a bug been filed to track this?
Filed Bug 47670