Bug 47395 – [EFL] Implement pageRect() function

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Gyuyoung Kim]

I understand that the pageRect returns layout size. I implement it using frameRect() of WidgetEfl.cpp.

[Gyuyoung Kim]

Created attachment 70197 [details]
Patch

[Gyuyoung Kim]

This patch passes to EWS for EFL port. :-)

- http://webkit-commit-queue.appspot.com/
- http://webkit-commit-queue.appspot.com/queue-status/efl-ews

[Antonio Gomes]

For Qt, it was implement as the viewport size:

113 FloatRect ChromeClientQt::pageRect() 
114 { 
115     if (!m_webPage) 
116         return FloatRect(); 
117     return FloatRect(QRectF(QPointF(0, 0), m_webPage->viewportSize())); 
118 }

although it seems like gtk returns the "page" size as well:


113 FloatRect ChromeClientQt::pageRect() 
114 { 
115     if (!m_webPage) 
116         return FloatRect(); 
117     return FloatRect(QRectF(QPointF(0, 0), m_webPage->viewportSize())); 
118 }


They are missing consistency(?)

[Gyuyoung Kim]

Created attachment 70199 [details]
Patch

I understand that QT port is using frameRect() as well as this patch.  So, I also use the frameRect().
The frameRect() returns frameview size.

QSize QWebPage::viewportSize() const
{
    if (d->mainFrame && d->mainFrame->d->frame->view())
        return d->mainFrame->d->frame->view()->frameRect().size();

    return d->viewportSize;
}

And, I add null checking code.

[WebKit Commit Bot]

Comment on attachment 70199 [details]
Patch

Clearing flags on attachment: 70199

Committed r69376: <http://trac.webkit.org/changeset/69376>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.